Postgres Pro
Downloads
Home   >   mailing lists

Re: Move backup-related code to xlogbackup.c/.h - Mailing list pgsql-hackers

From Gregory Stark (as CFM)
Subject Re: Move backup-related code to xlogbackup.c/.h
Date
Msg-id CAM-w4HOpUi3bCX+g=FDXpDg9d=OEaYWmmVnjg_WPAZGMTcyOAQ@mail.gmail.com
Whole thread Raw
In response to Re: Move backup-related code to xlogbackup.c/.h  (Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>)
List pgsql-hackers
Tree view 
On Wed, 26 Oct 2022 at 02:08, Bharath Rupireddy
<bharath.rupireddyforpostgres@gmail.com> wrote:
>
> I'm attaching the v9 patch set herewith after rebasing. Please review
> it further.

It looks like neither reviewer has been really convinced this is the
direction they want to go and I think that's why the thread has been
pretty dead since last October. I think people are pretty hesitant to
give bad news but I don't think we're doing you any favours having you
rebasing and rebasing and trying to justify specific code changes when
it looks like people are skeptical about the basic approach.

So I'm going to mark this Rejected for now. Perhaps a fresh approach
next release cycle starting with a discussion of the specific goals
rather than starting with a patch would be better.

-- 
Gregory Stark
As Commitfest Manager

pgsql-hackers by date:

Previous
From: Bharath Rupireddy
Date:
Subject: Re: add log messages when replication slots become active and inactive (was Re: Is it worth adding ReplicationSlot active_pid to ReplicationSlotPersistentData?)
Next
From: Greg Stark
Date:
Subject: Re: add log messages when replication slots become active and inactive (was Re: Is it worth adding ReplicationSlot active_pid to ReplicationSlotPersistentData?)