Postgres Pro
Downloads
Home   >   mailing lists

Re: Free indexed_tlist memory explicitly within set_plan_refs() - Mailing list pgsql-hackers

From Peter Geoghegan
Subject Re: Free indexed_tlist memory explicitly within set_plan_refs()
Date
Msg-id CAM3SWZTKHVArKZ_4Y9_ReL9mh-jBJoMULX9LCH+bfme7rkyTEg@mail.gmail.com
Whole thread Raw
In response to Re: Free indexed_tlist memory explicitly within set_plan_refs()  (Andres Freund <andres@anarazel.de>)
Responses Re: Free indexed_tlist memory explicitly within set_plan_refs()
List pgsql-hackers
Tree view 
On Fri, Jul 24, 2015 at 2:58 AM, Andres Freund <andres@anarazel.de> wrote:
> I've pushed a version of your patch. I just opted to remove p_is_update
> instead of allowing both to be set at the same time. To me that seemed
> simpler.

I would be hesitant to remove a struct field from a struct that
appears as a hook argument. Someone's extension (that uses parser
hooks) might have been relying on that. Perhaps not a big deal.

Thanks
-- 
Peter Geoghegan

pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: Supporting TAP tests with MSVC and Windows
Next
From: Jim Nasby
Date:
Subject: Re: Improving replay of XLOG_BTREE_VACUUM records