Re: BUG #18187: Unexpected error: "variable not found in subplan target lists" triggered by JOIN - Mailing list pgsql-bugs

From Richard Guo
Subject Re: BUG #18187: Unexpected error: "variable not found in subplan target lists" triggered by JOIN
Date
Msg-id CAMbWs49-1VhtQ4CXU+RBB5oaYg5viPgk_utp0HFii2LJ_wbEdw@mail.gmail.com
Whole thread Raw
In response to Re: BUG #18187: Unexpected error: "variable not found in subplan target lists" triggered by JOIN  (Andrei Lepikhov <a.lepikhov@postgrespro.ru>)
Responses Re: BUG #18187: Unexpected error: "variable not found in subplan target lists" triggered by JOIN
List pgsql-bugs

On Thu, Dec 7, 2023 at 10:55 AM Andrei Lepikhov <a.lepikhov@postgrespro.ru> wrote:
According to the patches:
0001 - looks good for me.
0002 - I don't understand why to use 'explain' in VERBOSE mode in tests.
What do you try to detect here?

The VERBOSE mode is used to observe that PHVs are adjusted correctly and
put in the right targetlist.
 
0003 - ok, but too short. Maybe squash all these patches into one?

It seems to me that these three patches are addressing separate issues
and are independent of each other.  For instance, the issue addressed by
0001 exists on master even without other changes, and 0002 is an
improvement that does not depend on others, while 0003 is a fix of an
incorrect comment.  I don't think it's a good idea to squash them into
one.
 
I think these corrections are good enough for commit.

Thank you for reviewing these patches.  Alexander, what are your
thoughts on these patches?

Thanks
Richard

pgsql-bugs by date:

Previous
From: Kyotaro Horiguchi
Date:
Subject: Re: BUG #18241: PushTransaction may cause Standby to execute ItemIdMarkDead
Next
From: Michael Paquier
Date:
Subject: Re: BUG #18241: PushTransaction may cause Standby to execute ItemIdMarkDead