Re: foreign join error "variable not found in subplan target list" - Mailing list pgsql-bugs

From Richard Guo
Subject Re: foreign join error "variable not found in subplan target list"
Date
Msg-id CAMbWs4_8ACt0b8Z8PTkSg9RbE1_OTsbA25k0OFp+faxBT9tuuQ@mail.gmail.com
Whole thread Raw
In response to Re: foreign join error "variable not found in subplan target list"  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-bugs

On Tue, Aug 30, 2022 at 10:04 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
Richard Guo <guofenglinux@gmail.com> writes:
> To be concrete, I mean something like this:

> +               /* Update the cost and width fields if we have added any
> new columns. */
> +               if (!equal(epq_path->pathtarget->exprs, target->exprs))
> +                       set_pathtarget_cost_width(root, target);

Wouldn't a list_length() comparison be sufficient?  equal() seems
like overkill.
 
Yeah, list_length comparison would do, as we only append new columns
here. Thanks for the suggestion!

Thanks
Richard

pgsql-bugs by date:

Previous
From: Kyotaro Horiguchi
Date:
Subject: Re: BUG #17601: Problem running the post-install step. Installation may not complete correctly.
Next
From: Amit Kapila
Date:
Subject: Re: Excessive number of replication slots for 12->14 logical replication