Re: [PATCH] Add an ldflags_sl meson build option - Mailing list pgsql-hackers

From Nazir Bilal Yavuz
Subject Re: [PATCH] Add an ldflags_sl meson build option
Date
Msg-id CAN55FZ3OzZhQ0nx3O+EyJSj8dmLotyYN9KSDDGRRpZhF7fcMGw@mail.gmail.com
Whole thread Raw
In response to [PATCH] Add an ldflags_sl meson build option  ("Matt Smith (matts3)" <matts3@cisco.com>)
List pgsql-hackers
Hi,

On Mon, 16 Jun 2025 at 14:26, Matt Smith (matts3) <matts3@cisco.com> wrote:
>
> Currently there doesn't seem to be a way to pass shared library-specific flags via a meson build option.
>
> This patch allows the existing ldflags_sl to be set via a build option.
>
> Patch created against the 17.4 release.

The patch looks correct.

+option('ldflags_sl', type: 'array', value: [],
+  description: 'Shared library ldflags')

nitpick: I would suggest using the same description from autoconf
build: 'extra linker flags for linking shared libraries only'.

-- 
Regards,
Nazir Bilal Yavuz
Microsoft



pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: pg_recvlogical cannot create slots with failover=true
Next
From: jian he
Date:
Subject: Re: confusing message in check_tuple