Re: Issue with markers in isolation tester? Or not? - Mailing list pgsql-hackers

From Michail Nikolaev
Subject Re: Issue with markers in isolation tester? Or not?
Date
Msg-id CANtu0ogADxLyenSge53fVXQpA+h2q=Q8Zy2vVpLBR-EbxXcVng@mail.gmail.com
Whole thread Raw
In response to Re: Issue with markers in isolation tester? Or not?  (Noah Misch <noah@leadboat.com>)
List pgsql-hackers
Hello, Noah!

> I misunderstood, and I was mistaken to see this as a bug fix.  The
>  isolationtester is acting per its definition, and this would be a definition
>  change.

Yes, you are right, but I think it is better to clarify it somehow because from my point of view that definition feels like logic in patched version.
But maybe my non-native English prevents me from understanding it correctly.

In my opinion, it is better to add some clarification like "this marker affects only other steps which were launched before this step or during its execution".

> I'd need to review the motivating test to form my own opinion on whether the
> new definition makes it easier to write tests.
> You could bundle this in the thread that wants this to stabilize that thread's CI results.

I'll think about it, but currently it is stabilized using "notices" and, you know, more changes - harder to merge :)

Also, I'll try one more time to stabilize it without "notices" - maybe I'll get some insight.
Anyway - I'll ping you in that thread [0] (you're already in recipients) or bring it here.

Best regards,
Mikhail.

pgsql-hackers by date:

Previous
From: Masahiko Sawada
Date:
Subject: Re: Conflict detection for update_deleted in logical replication
Next
From: Tom Lane
Date:
Subject: Re: convert libpgport's pqsignal() to a void function