Request a Demo
Home   >   mailing lists

Re: convert libpgport's pqsignal() to a void function - Mailing list pgsql-hackers

From Tom Lane
Subject Re: convert libpgport's pqsignal() to a void function
Date
Msg-id 1164438.1736910166@sss.pgh.pa.us
Whole thread Raw
Responses Re: convert libpgport's pqsignal() to a void function
List pgsql-hackers
Tree view 
Nathan Bossart <nathandbossart@gmail.com> writes:
> Thanks to commit 9a45a89, legacy-pqsignal.c now has its own dedicated
> extern for pqsignal(), which decouples it enough that we can follow through
> with changing libpqport's pqsignal() to a void function.

> Thoughts?

LGTM, although I don't know enough about Windows to know if the
"== SIG_ERR" test in that path is correct.

            regards, tom lane

pgsql-hackers by date:

Previous
From: Michail Nikolaev
Date:
Subject: Re: Issue with markers in isolation tester? Or not?
Next
From: vignesh C
Date:
Subject: Re: Introduce XID age and inactive timeout based replication slot invalidation