Re: BUG #16108: Colorization to the output of command-line hasunproperly behaviors at Windows platform - Mailing list pgsql-hackers

From Michail Nikolaev
Subject Re: BUG #16108: Colorization to the output of command-line hasunproperly behaviors at Windows platform
Date
Msg-id CANtu0oic8bkGZ6uSA6NPp=dKCwpBd22yk2tJmUKCX5PVVAzMDA@mail.gmail.com
Whole thread Raw
In response to Re: BUG #16108: Colorization to the output of command-line hasunproperly behaviors at Windows platform  (Juan José Santamaría Flecha <juanjo.santamaria@gmail.com>)
Responses Re: BUG #16108: Colorization to the output of command-line hasunproperly behaviors at Windows platform
List pgsql-hackers
Hello.

> The patch about making color by default [1] introduces the function terminal_supports_color(), that I think is
relevantfor this issue. Please find attached a new version based on that idea.
 

I am not sure it is good idea to mix both patches because it adds some
confusion and makes it harder to merge each.
Maybe is it better to update current patch the way to reuse some
function later in [1]?

Also, regarding comment
> It is disabled by default, so it must be enabled to use color outpout.

It is not true for new terminal, for example. Maybe it is better to
rephrase it to something like: "Check if TV100 support if enabled and
attempt to enable if not".

[1] https://www.postgresql.org/message-id/flat/bbdcce43-bd2e-5599-641b-9b44b9e0add4@2ndquadrant.com



pgsql-hackers by date:

Previous
From: Jeff Davis
Date:
Subject: Re: Memory-Bounded Hash Aggregation
Next
From: Daniel Gustafsson
Date:
Subject: Re: Ought to use heap_multi_insert() for pg_attribute/dependinsertions?