Re: Fixed issue "Error Message is displayed when the Package is Clicked" - Mailing list pgadmin-hackers
| From | Akshay Joshi |
|---|---|
| Subject | Re: Fixed issue "Error Message is displayed when the Package is Clicked" |
| Date | |
| Msg-id | CANxoLDc0BwEt3T+ipKRFpKLJ339KyDBGrdJ+v02gLb-jX_5rJQ@mail.gmail.com Whole thread Raw |
| In response to | Re: Fixed issue "Error Message is displayed when the Package is Clicked" (Dave Page <dpage@pgadmin.org>) |
| Responses |
Re: Fixed issue "Error Message is displayed when
the Package is Clicked"
|
| List | pgadmin-hackers |
On Mon, Mar 19, 2012 at 8:12 PM, Dave Page <dpage@pgadmin.org> wrote:
On Mon, Mar 19, 2012 at 2:35 PM, Akshay JoshiHmm, that looks like something changed in 9.1 that needs handling<akshay.joshi@enterprisedb.com> wrote:
> Hi
>
> On Mon, Mar 19, 2012 at 7:29 PM, Dave Page <dpage@pgadmin.org> wrote:
>>
>> Hi
>>
>> On Thu, Mar 15, 2012 at 2:59 PM, Akshay Joshi
>> <akshay.joshi@enterprisedb.com> wrote:
>> > Hi Dave
>> >
>> > I have fixed one issue "Error Message is displayed when the Package is
>> > Clicked". I have performed the following on enterprisedb database
>> >
>> > create or replace package pkgFoo is
>> > procedure foo(
>> > arg1 IN varchar default 'Nothing',
>> > arg2 IN integer default 100
>> > );
>> > end pkgFoo;
>> >
>> > create or replace package body pkgFoo is
>> > procedure foo(
>> > arg1 IN varchar default 'Nothing',
>> > arg2 IN integer default 100
>> > ) is
>> > begin
>> > dbms_output.put_line(arg1);
>> > dbms_output.put_line(arg2);
>> > end;
>> > end pkgFoo;
>> >
>> > Now click on pkgFoo, we will get the error message.It only happens the
>> > first
>> > time.
>>
>> I cannot reproduce the error, using GIT Master with PPAS 9.0 on CentOS 5.
>
>
> I am able to reproduce this every first time after launching pgAdmin using
> GIT Master with PPAS9.1 on Windows 7. Attached is the screen shot.
>>
>>
>> > Attached is the patch file, please review it. If it looks good then
>> > please
>> > commit it.
>>
>> The patch is wrong. The restriction is supposed to be " = 'void'" for
>> procedures, and " != 'void'" for functions, as it already is.
>
>
> OK. I am not much aware of that code, but we have to provide some other
> fix for the mentioned issue.
differently. Can you work out exactly what the query that causes the
error is? We may need to check with one of the server guys.
I am able to reproduce the same issue with PPAS 9.0. Below is the query for PPAS 9.0 and 9.1 which causes the error
PPAS 9.0 :- SELECT pg_get_expr('{CONST :consttype 1043 :consttypmod -1 :constcollid 100 :constlen -1 :constbyval false :constisnull false :location 283 :constvalue 11 [ 44 0 0 0 78 111 116 104 105 110 103 ]} {CONST :consttype 23 :consttypmod -1 :constcollid 0 :constlen 4 :constbyval true :constisnull false :location 334 :constvalue 4 [ 100 0 0 0 ]}', 'pg_catalog.pg_class'::regclass)
PPAS 9.1 :- SELECT pg_get_expr('{CONST :consttype 1043 :consttypmod -1 :constcollid 100 :constlen -1 :constbyval false :constisnull false :location 290 :constvalue 11 [ 44 0 0 0 78 111 116 104 105 110 103 ]} {CONST :consttype 23 :consttypmod -1 :constcollid 0 :constlen 4 :constbyval true :constisnull false :location 342 :constvalue 4 [ 100 0 0 0 ]}', 'pg_catalog.pg_class'::regclass)
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Akshay Joshi
Senior Software Engineer
EnterpriseDB Corporation
The Enterprise PostgreSQL Company
Phone: +91 20-3058-9522
Mobile: +91 976-788-8246
Senior Software Engineer
EnterpriseDB Corporation
The Enterprise PostgreSQL Company
Phone: +91 20-3058-9522
Mobile: +91 976-788-8246
pgadmin-hackers by date: