Re: [pgAdmin][RM4979]: Configuration files for data sources or similar. - Mailing list pgadmin-hackers
Hi Pradip
Following are the GUI review comments:
Testing Scenario: I have three users U1 and U2 are Admin and U3 is a normal user. Login from U1 first time and pgAdmin4 discover all the local servers. Steps that I perform:
- Shared one server.
- Create a group 'Test' and move one server to that group.
- Share the server of the 'Test' group as well.
Issues:
- When login using U2 or U3 PostgreSQL 9.2 and 10 shown twice which should not. Refer below screenshot
- When expanding the server or clicking on the 'Connect Server' menu of the shared server, it opens the properties dialog.
- Try to update the IPAddress, Port it is not updating for the shared server. Check other properties too.
- When we set "Hide shared server?" setting to true/false. A complete browser tree should be refreshed. With the current implementation, each group needs to be refreshed individually and the server group still visible while refreshing the complete page Browser Tree looks perfect.
- When there is only one server in a group and we expanded the group 'Connect to server' dialog appears which should not. (*This may be an old issue)
- Schema Diff shared servers are not visible inside the appropriate group in the source and target server list.
- Documentation changes required (Create a new Redmine).
- SonarQube shows 1 new Bug and 4 new code smell. (Fixed the Bug, code smell can be fixed later)
- 'pgAdmin4_test_non_admin_credentials' should be added in 'test_config.json.in' file.
- For Desktop mode shared server test cases should be skipped. It is failing at the moment.
On Fri, Aug 21, 2020 at 6:00 PM Pradip Parkale <pradip.parkale@enterprisedb.com> wrote:
Hi Akshay,Please find the updated patch.On Fri, Aug 21, 2020 at 1:55 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:Hi PradipThe patch is not applied, can you please rebase and send it again.On Thu, Aug 20, 2020 at 3:58 PM Pradip Parkale <pradip.parkale@enterprisedb.com> wrote:Hi Hackers,Please find the attached patch for the shared server implementation.Few key points:
- The admin who is the owner of the server user can share the server with other users.
- This option will be available only for admin users.
- If the user doesn't want to see the shared server then the option to hide the shared server is available in preferences.
- The user who is not the owner of the server, can't delete the shared server and server group.
- This option is only available in server mode.
--Thanks & Regards,Pradip Parkale
Software Engineer | EnterpriseDB Corporation
--Thanks & RegardsAkshay JoshipgAdmin Hacker | Sr. Software ArchitectEDB PostgresMobile: +91 976-788-8246--Thanks & Regards,Pradip Parkale
Software Engineer | EnterpriseDB Corporation
--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Sr. Software Architect
EDB PostgresMobile: +91 976-788-8246
Attachment
pgadmin-hackers by date: