Re: pgsql: Track block level checksum failures in pg_stat_database - Mailing list pgsql-committers

From Julien Rouhaud
Subject Re: pgsql: Track block level checksum failures in pg_stat_database
Date
Msg-id CAOBaU_Y0oSe=nQLujkj_GD-KKC29rtfUL-Eb66w4a=XaC7rumA@mail.gmail.com
Whole thread Raw
In response to Re: pgsql: Track block level checksum failures in pg_stat_database  (Tomas Vondra <tomas.vondra@2ndquadrant.com>)
Responses Re: pgsql: Track block level checksum failures in pg_stat_database
List pgsql-committers
On Tue, Apr 30, 2019 at 6:33 PM Tomas Vondra
<tomas.vondra@2ndquadrant.com> wrote:
>
> On Sat, Mar 09, 2019 at 06:48:11PM +0000, Magnus Hagander wrote:
> >Track block level checksum failures in pg_stat_database
> >
> >This adds a column that counts how many checksum failures have occurred
> >on files belonging to a specific database. Both checksum failures
> >during normal backend processing and those created when a base backup
> >detects a checksum failure are counted.
> >
>
> It seems this commit forgot to add PgStat_MsgChecksumFailure to the
> PgStat_Msg union.

Oops, indeed.  That's embarrassing.  Trivial fix attached if that helps.

Attachment

pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Clean up handling of constraint_exclusion andenable_partition_p
Next
From: Tom Lane
Date:
Subject: Re: pgsql: Track block level checksum failures in pg_stat_database