Postgres Pro
Downloads
Home   >   mailing lists

Re: [HACKERS] Crash when partition column specified twice - Mailing list pgsql-hackers

From Beena Emerson
Subject Re: [HACKERS] Crash when partition column specified twice
Date
Msg-id CAOG9ApHcs+sLQzDASrCk=DN=Gxoe=UF4ZBs-4=nBZGPeHqa0GQ@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] Crash when partition column specified twice  (Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>)
Responses Re: [HACKERS] Crash when partition column specified twice
List pgsql-hackers
Tree view
Hello Amit,

The extra n->is_from_type = false; seems to be added by mistake?

@@ -11888,6 +11891,8 @@ TableFuncElement:   ColId Typename opt_collate_clause
                    n->is_local = true;
                    n->is_not_null = false;
                    n->is_from_type = false;
+                   n->is_from_type = false;
+                   n->is_from_parent = false;
                    n->storage = 0;
                    n->raw_default = NULL;
                    n->cooked_default = NULL;



On Fri, Apr 28, 2017 at 6:08 AM, Amit Langote <Langote_Amit_f8@lab.ntt.co.jp> wrote:
On 2017/04/27 12:36, Amit Langote wrote:
> Noticed that a crash occurs if a column is specified twice when creating a
> partition:
>
> create table p (a int) partition by list (a);
>
> -- crashes
> create table p1 partition of parent (
>   a not null,
>   a default 1
> ) for values in (1);
>
> The logic in MergeAttributes() that merged partition column options with
> those of the parent didn't properly check for column being specified twice
> and instead tried to delete the same ColumnDef from a list twice, causing
> the crash.
>
> Attached fixes that.

Patch rebased, because of a conflict with b9a3ef55b2.

Thanks,
Amit


--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers




--

Beena Emerson

EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgsql-hackers by date:

Previous
From: 高增琦
Date:
Subject: Re: [HACKERS] Dropping a partitioned table takes too long
Next
From: Craig Ringer
Date:
Subject: Re: [HACKERS] On How To Shorten the Steep Learning Curve Towards PG Hacking...