Re: macos exported symbols list not used for loadable modules - Mailing list pgsql-hackers

From Jacob Champion
Subject Re: macos exported symbols list not used for loadable modules
Date
Msg-id CAOYmi+kPMkcWNaUOrjS=SMi+SUfR-pY_egXYX3LymBGu1gjq3A@mail.gmail.com
Whole thread Raw
List pgsql-hackers
On Tue, Jun 3, 2025 at 12:48 AM Peter Eisentraut <peter@eisentraut.org> wrote:
>
> On macOS, when building with the make system, the exported symbols list
> (SHLIB_EXPORTS) is ignored.  I don't think that is intentional.  It was
> probably just forgotten, since that combination has never actually been
> used until now (for libpq-oauth).

Oops, thank you for noticing that.

> (Alternatively: Am I missing something?  Is this combination not useful?
>   Was it not supported in older versions at some point?  I couldn't
> think of anything.)
>
> The meson build system handles this correctly.
>
> I suggest that we fix this.  I attach patch 0001 with a minimal fix,
> patch 0002 is a bit more refactoring to make the code match the layout
> for other platforms.

LGTM, and works on my machine. Unfortunately I don't have any insight
into the history.

Thanks!
--Jacob



pgsql-hackers by date:

Previous
From: Álvaro Herrera
Date:
Subject: Re: ABI Compliance Checker GSoC Project
Next
From: Andres Freund
Date:
Subject: Re: postmaster uses more CPU in 18 beta1 with io_method=io_uring