Re: Add missing error codes to PANIC/FATAL error reports in xlogrecovery - Mailing list pgsql-hackers

From Krishnakumar R
Subject Re: Add missing error codes to PANIC/FATAL error reports in xlogrecovery
Date
Msg-id CAPMWgZ_EtJjK=hutDqjBFTMjLoxumzKOkRAtdPNQJsr1ECXtig@mail.gmail.com
Whole thread Raw
In response to Re: Add missing error codes to PANIC/FATAL error reports in xlogrecovery  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
Hi,

Updated the patch with ERRCODE_CLUSTER_CORRUPTED & kept
ERRCODE_DATA_CORRUPTED when recovery is not consistent.

> > > Hm, this one arguably is not corruption, but we still cannot
> > > continue. ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE or maybe a new error code?

Added a ERRCODE_TIMELINE_INCONSISTENT to be specific about the
scenarios with timeline mismatches. Thoughts ?

>> Another aside: Isn't the hint here obsolete since we've removed exclusive
backups? I can't think of any scenario now where removing backup_label would
be correct in a non-exclusive backup.

Attached another patch which applies on top of the first patch to
remove the obsolete hint.

- KK

Attachment

pgsql-hackers by date:

Previous
From: Richard Guo
Date:
Subject: Re: A wrong comment about search_indexed_tlist_for_var
Next
From: John Naylor
Date:
Subject: Re: Add pg_basetype() function to obtain a DOMAIN base type