Postgres Pro
Downloads
Home   >   mailing lists

Re: [HACKERS] [PATCH] Incremental sort - Mailing list pgsql-hackers

From Alexander Korotkov
Subject Re: [HACKERS] [PATCH] Incremental sort
Date
Msg-id CAPpHfdsn20cxCeO3pMEhgZpAYkHg1s_be6GS9-PP4Q0UxOnX7w@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] [PATCH] Incremental sort  (Teodor Sigaev <teodor@sigaev.ru>)
List pgsql-hackers
Tree view
On Sat, Apr 7, 2018 at 5:37 PM, Teodor Sigaev <teodor@sigaev.ru> wrote:
by this patch.  Revised version is attached.

 Fine, patch got several rounds of review in all its parts. Is any places which should be improved before commit?

Also I found that after planner changes of Alexander Kuzmenkov, incremental sort
was used in cheapest_input_path() only if its child is cheapest total path.
That makes incremental sort to not get used almost never.
I've changed that to consider incremental sort path when we have some
presorted columns.  I also have to put changes in postgres_fdw regression
tests back, because incremental sort was used right there.

This revision of the patch also includes commit message.

------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company 
Attachment

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Online enabling of checksums
Next
From: Tom Lane
Date:
Subject: Re: [HACKERS] [PATCH] Incremental sort