Postgres Pro
Downloads
Home   >   mailing lists

pgsql: File size in a backup manifest should use uint64, not size_t. - Mailing list pgsql-committers

From Robert Haas
Subject pgsql: File size in a backup manifest should use uint64, not size_t.
Date
Msg-id E1sw02e-001rfO-2f@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Tree view 
File size in a backup manifest should use uint64, not size_t.

size_t is the size of an object in memory, not the size of a file on disk.

Thanks to Tom Lane for noting the error.

Discussion: http://postgr.es/m/1865585.1727803933@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d94cf5ca7fad9cd81af5eac491bfbaf0facb9f6f

Modified Files
--------------
src/bin/pg_combinebackup/load_manifest.c   |  4 ++--
src/bin/pg_combinebackup/load_manifest.h   |  2 +-
src/bin/pg_combinebackup/write_manifest.c  |  5 +++--
src/bin/pg_combinebackup/write_manifest.h  |  2 +-
src/bin/pg_verifybackup/astreamer_verify.c | 13 ++++++++-----
src/bin/pg_verifybackup/pg_verifybackup.c  | 16 +++++++++-------
src/bin/pg_verifybackup/pg_verifybackup.h  |  2 +-
src/common/parse_manifest.c                |  4 ++--
src/include/common/parse_manifest.h        |  2 +-
9 files changed, 28 insertions(+), 22 deletions(-)

pgsql-committers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: pgsql: doc: Missing markup, punctuation and wordsmithing
Next
From: Tom Lane
Date:
Subject: pgsql: Parse libpq's "keepalives" option more like other integer option