pgsql: ecpg: avoid adding whitespace around '&' in connection URLs. - Mailing list pgsql-committers

From Tom Lane
Subject pgsql: ecpg: avoid adding whitespace around '&' in connection URLs.
Date
Msg-id E1swkkg-00291W-D5@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
ecpg: avoid adding whitespace around '&' in connection URLs.

The preprocessor really should not have done this to begin with.
The space after '&' was masked by ECPGconnect's skipping spaces
before option keywords, and the space before by dint of libpq
being (mostly) insensitive to trailing space in option values.
We fixed the one known problem with that in 920d51979.  Hence
this patch is mostly cosmetic, and we'll just change it in HEAD.

Discussion: https://postgr.es/m/TY2PR01MB36286A7B97B9A15793335D18C1772@TY2PR01MB3628.jpnprd01.prod.outlook.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/f22e84df1dea96c8f4b0f7369ea60607fbb9ce10

Modified Files
--------------
src/interfaces/ecpg/ecpglib/connect.c                  | 5 ++++-
src/interfaces/ecpg/preproc/ecpg.trailer               | 2 +-
src/interfaces/ecpg/test/expected/connect-test5.c      | 2 +-
src/interfaces/ecpg/test/expected/connect-test5.stderr | 2 +-
4 files changed, 7 insertions(+), 4 deletions(-)


pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: pgsql: Rename PageData to GenericXLogPageData
Next
From: Thomas Munro
Date:
Subject: pgsql: Reject non-ASCII locale names.