pgsql: Revert "Blind attempt to fix _configthreadlocale() failures on M - Mailing list pgsql-committers

From Thomas Munro
Subject pgsql: Revert "Blind attempt to fix _configthreadlocale() failures on M
Date
Msg-id E1tGF9x-003jv6-Dv@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Revert "Blind attempt to fix _configthreadlocale() failures on MinGW."

This reverts commit 2cf91ccb73ce888c44e3751548fb7c77e87335f2.

When using the old msvcrt.dll, MinGW would supply its own dummy version
of _configthreadlocale() that just returns -1 if you try to use it.  For
a time we tolerated that to shut the build farm up.  We would fall back
to code that was enough for the tests to pass, but it would surely have
risked crashing a real multithreaded program.

We don't need that kludge anymore, because we can count on ucrt.  We
expect the real _configthreadlocale() to be present, and the ECPG tests
will now fail if it isn't.  The workaround was dead code and it's time
to revert it.

(A later patch still under review proposes to remove this use of
_configthreadlocale() completely but we're unwinding this code in
steps.)

Reviewed-by: Peter Eisentraut <peter@eisentraut.org>
Discussion: https://postgr.es/m/d9e7731c-ca1b-477c-9298-fa51e135574a%40eisentraut.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/a62d90f2e5cb55d0c8998b63120d6db3c55df866

Modified Files
--------------
src/interfaces/ecpg/ecpglib/descriptor.c |  2 +-
src/interfaces/ecpg/ecpglib/execute.c    | 20 +++++++++-----------
2 files changed, 10 insertions(+), 12 deletions(-)


pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: pgsql: Improve slightly misleading internal error message
Next
From: Peter Eisentraut
Date:
Subject: pgsql: Exclude LLVM files from whitespace checks