Re: Fix error handling in be_tls_open_server() - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: Fix error handling in be_tls_open_server()
Date
Msg-id E3921399-FAE7-4B1F-B1BF-B3357DDC9F19@yesql.se
Whole thread Raw
In response to Fix error handling in be_tls_open_server()  (Sergey Shinderuk <s.shinderuk@postgrespro.ru>)
Responses Re: Fix error handling in be_tls_open_server()
Re: Fix error handling in be_tls_open_server()
List pgsql-hackers
> On 1 Aug 2023, at 16:44, Sergey Shinderuk <s.shinderuk@postgrespro.ru> wrote:

> A static analyzer reported a possible pfree(NULL) in be_tls_open_server().

This has the smell of a theoretical problem, I can't really imagine a
certificate where which would produce this.  Have you been able to trigger it?

Wouldn't a better fix be to error out on len == -1 as in the attached, maybe
with a "Shouldn't happen" comment?

--
Daniel Gustafsson


Attachment

pgsql-hackers by date:

Previous
From: David Rowley
Date:
Subject: meson uses stale pg_config_paths.h left over from make
Next
From: Pavel Stehule
Date:
Subject: Re: Schema variables - new implementation for Postgres 15