Postgres Pro
Downloads
Home   >   mailing lists

Re: Fix resource leak (src/backend/libpq/be-secure-common.c) - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: Fix resource leak (src/backend/libpq/be-secure-common.c)
Date
Msg-id F8483DF1-268F-44D3-8D3A-CCB333E2D81F@yesql.se
Whole thread Raw
In response to Re: Fix resource leak (src/backend/libpq/be-secure-common.c)  (Ranier Vilela <ranier.vf@gmail.com>)
Responses Re: Fix resource leak (src/backend/libpq/be-secure-common.c)
List pgsql-hackers
Tree view
On 10 Apr 2024, at 20:31, Ranier Vilela <ranier.vf@gmail.com> wrote:

Em ter., 2 de abr. de 2024 às 15:31, Daniel Gustafsson <daniel@yesql.se> escreveu:
> On 2 Apr 2024, at 20:13, Ranier Vilela <ranier.vf@gmail.com> wrote:

> Fix by freeing the pointer, like pclose_check (src/common/exec.c) similar case.

Off the cuff, seems reasonable when loglevel is LOG.

Per Coverity.

Another case of resource leak, when loglevel is LOG.
In the function shell_archive_file (src/backend/archive/shell_archive.c)
The pointer *xlogarchcmd*  is not freed.

Thanks, I'll have a look.  I've left this for post-freeze on purpose to not
cause unnecessary rebasing.  Will take a look over the next few days unless
beaten to it.

--
Daniel Gustafsson

pgsql-hackers by date:

Previous
From: Jelte Fennema-Nio
Date:
Subject: Re: psql: Greatly speed up "\d tablename" when not using regexes
Next
From: Jelte Fennema-Nio
Date:
Subject: Re: psql: Greatly speed up "\d tablename" when not using regexes