Re: 7.2 stuff - Mailing list pgsql-hackers

Hi,

Tom - there's a comment for you further down...

> > This problem is also what's stopped me submitting the ALTER TABLE / ADD
> > PRIMARY stuff.  Once the ADD UNIQUE bit is correct, ADD PRIMARY
> is trivial.
> >
> > (See: http://fts.postgresql.org/db/mw/msg.html?mid=1035632)  I suggest
> > reading the complete thread.  I have fixed some of the problems in my
> > private cvs, but no patch has been sent in...
> >
> > Some of the issues perhaps I should send in a patch for ASAP??

All of the above is a non-issue - it was implemented by tom in the parser,
and my code was removed.  Howver, add primary key needs a regression test.

> > > key already exists
> > > > over the specified fields
> > > > * PSQL - SHOW FOREIGN KEYS
> > > >     - Still working on a query.  If I come up with a good one -
> > > would a catalog
> > > > view of them be useful?
> >
> > Is there a pg_get_* function for getting foreign key definitions yet?

I still want to do the above - however Stephen Sazbo has ideas about
changing all the fk stuff...

> > > > * -ALTER TABLE DROP CHECK
> > > >     - Already committed
> >
> > Yeah, committed.

Committed - it needs a regression test tho.

> > > > * ALTER TABLE DROP PRIMARY KEY
> > > >     - Done, will need review
> > > > * ALTER TABLE DROP UNIQUE
> > > >     - Done, will need review
> >
> > Wrote them, but they're uncommitted.  Don't worry about them until 7.3.

I'll dredge this up again if I can.  All it does is add a standards
compliant alternative syntax for dropping those constraints.  Tom - can you
just do this in the parser, like you did it for the ADD constraints???

> > > > * ALTER TABLE DROP FOREIGN KEY
> > > >     - Harder than I thought :) Working on it.
> >
> > This is a toughie this one!

And also depends on future fk changes.

> > > > * Check that pgclass.relfkeys is being set correctly.
> > > >     - Is pgclass.relfkeys being used at the moment?
> >
> > It looked to me that pgclass.relfkeys wasn't ever being set or
> updated.  Is
> > this true/correct?

Correct.

> > > > * WILDCARDS IN PG_DUMP
> > > >     - It would be nice to be able to dump tables via wildcards,
> > > or once schemas
> > > > exist to dump an entire schema I guess.
> >
> > That was just one of my little wish lists.  I have a database
> with about a
> > hundred tables in it and related sets of tables all share the
> same prefix.
> > For instance, I would like to be able to pg_dump all the diary
> tables in one
> > go.
> >
> > ie. pg_dump -t diary_\* audb > dump.sql
> >
> > Don't know if there would be widespread enough demand for this feature
> > tho...

The above would be a nice feature...

> > > > * CHECK CREATING DUPLICATE NAMED FOREIGN KEYS
> > > >     - I seem to be able to create duplicate named fk's,
> plus I think the
> > > > '<unnamed>' ones should be given auto name to make dropping
> constraint
> > > > easier...
> >
Pretty clear.

Chris