RE: [PATCH]Comment improvement in publication.sql - Mailing list pgsql-hackers

On Monday, August 2, 2021 11:56 PM vignesh C <vignesh21@gmail.com> wrote:
> 
> Few minor suggestions:
> 1) Should we change below to "fail - tables can't be added, dropped or
> set to "FOR ALL TABLES" publications"
> --- fail - can't add to for all tables publication
> +-- fail - tables can't be added to or dropped from FOR ALL TABLES publications

Thanks for your kindly comments.

I'm not sure should we ignore that 'drop' should be followed by 'from', but I
think there's no misunderstandings. So, modified as you described.

Besides, in other file comments (src/test/subscription/t/100_bugs.pl) I saw FOR ALL TABLES without using quotes. 
So I don't think we need the quotes, too.

> 2) Should we change this to "--fail - already existing publication"
> --- fail - already added
> +-- fail - already exists

Modified.

A modified patch is attached.

Regards
Tang