Missing program_XXX calling in pgbench tests - Mailing list pgsql-hackers

From Hayato Kuroda (Fujitsu)
Subject Missing program_XXX calling in pgbench tests
Date
Msg-id OSCPR01MB14966247015B7E3D8D340D022F56FA@OSCPR01MB14966.jpnprd01.prod.outlook.com
Whole thread Raw
Responses Re: Missing program_XXX calling in pgbench tests
List pgsql-hackers
Dear hackers,

While reviewing another thread I found #SUBJECT.

Most of client program executes program_help_ok, program_version_ok,
program_options_handling_ok() in their test, but pgbench does not do. Instead
pgbench has own tests for --help and --version options.

One concern is that program_help_ok() checks whether lines are too long or not.
For now, the rule seems to be kept but not sure in future.

I feel that we can replace tests with common function, like attached. How do you
think?

Best regards,
Hayato Kuroda
FUJITSU LIMITED


Attachment

pgsql-hackers by date:

Previous
From: Yugo Nagata
Date:
Subject: psql: tab-completion support for COPY ... TO/FROM STDIN, STDOUT, and PROGRAM
Next
From: Michael Paquier
Date:
Subject: Re: a couple of small cleanup patches for DSM-related code