RE: [PATCH] Proposal: Improvements to PDF stylesheet and table column widths - Mailing list pgsql-hackers

From Hayato Kuroda (Fujitsu)
Subject RE: [PATCH] Proposal: Improvements to PDF stylesheet and table column widths
Date
Msg-id OSCPR01MB14966B70DC510DEB6262D5CE5F56BA@OSCPR01MB14966.jpnprd01.prod.outlook.com
Whole thread Raw
In response to [PATCH] Proposal: Improvements to PDF stylesheet and table column widths  (Noboru Saito <noborusai@gmail.com>)
Responses Re: [PATCH] Proposal: Improvements to PDF stylesheet and table column widths
List pgsql-hackers
Dear Saito-san,

> - A patch that adds margins to admonition blocks.
> - An updated image where I have highlighted the space with a red
> border for clarity.
> 
> The image shows:
> - The original layout (top left)
> - Only indentation set to 0 (top right)
> - Indentation 0 plus admonition margins (bottom right)

To confirm, the top-right was generated with the previous patch, and bottom-right
was generated v2 patch, right? I prefer the bottom-right one.

BTW, I can suggest separating patches like:

0001 - setting both body.start.indent and body.end.indent to 0
0002 - set margin-left and margin-right to 0.25in

This approach makes us easier to understand and discuss, i.e., someone only loves
0001. They can be combined by committers when they push changes.
To create a series of patches, you can git format-patch command can be used.
Please refer [1] for more detail.


[1]: https://git-scm.com/book/en/v2/Appendix-C:-Git-Commands-Email

Best regards,
Hayato Kuroda
FUJITSU LIMITED


pgsql-hackers by date:

Previous
From: Shinya Kato
Date:
Subject: Extend COPY FROM with HEADER to skip multiple lines
Next
From: wenhui qiu
Date:
Subject: Re: [PATCH] Refactor: Extract XLogRecord info