RE: PGdoc: add missing ID attribute to create_subscription.sgml - Mailing list pgsql-hackers

From Hayato Kuroda (Fujitsu)
Subject RE: PGdoc: add missing ID attribute to create_subscription.sgml
Date
Msg-id TYAPR01MB5866C8D269A6CB585855C394F58B9@TYAPR01MB5866.jpnprd01.prod.outlook.com
Whole thread Raw
In response to Re: PGdoc: add missing ID attribute to create_subscription.sgml  (Peter Smith <smithpb2250@gmail.com>)
Responses Re: PGdoc: add missing ID attribute to create_subscription.sgml
List pgsql-hackers
Dear Peter,

Thank you for reviewing! PSA new version.

> doc/src/sgml/logical-replication.sgml
> 
> 1.
> I am not sure your convention to only give the link to the FIRST
> reference on a page is good in all case. Maybe that rule is OK for
> multiple references all in the same sub-section but when they are in
> different sub-sections (even on one page) I think it would be better
> to include the extra links.

Sounds better for readability.

> 1a.
> For example, Section 33.3 (Row Filter) refers to
> "publish_via_partition_root" lots of times across multiple subsections
> – So it is not convenient to have to scroll around looking in
> different sections for the topmost reference which has the link.

Added only two links because almost lines were in the same sub-section(Examples).
Did it match with your expectation?

> 1b.
> Also in Section 33.3 (Row Filter), there are a couple of places you
> could link to "publish" parameter on this page.

IIUC there was only one point to add the link, but added.

Also, I have added further links for "FOR ALL TABLES" and "FOR TABLES IN SCHEMA" clauses.

> 2.
> I thought was a missing link in 31.7.1 (Architecture/Initial Snapshot)
> which could've linked to the "publish" parameter.
>

Added.

Best Regards,
Hayato Kuroda
FUJITSU LIMITED


Attachment

pgsql-hackers by date:

Previous
From: "Hayato Kuroda (Fujitsu)"
Date:
Subject: RE: PGdoc: add missing ID attribute to create_subscription.sgml
Next
From: Kyotaro Horiguchi
Date:
Subject: Re: awkward cancellation of parallel queries on standby.