Re: pgsql: Fix pattern matching logic for logs in TAP tests of pgbench - Mailing list pgsql-committers

From Michael Paquier
Subject Re: pgsql: Fix pattern matching logic for logs in TAP tests of pgbench
Date
Msg-id YNVIrQEl8voobc3y@paquier.xyz
Whole thread Raw
In response to Re: pgsql: Fix pattern matching logic for logs in TAP tests of pgbench  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: pgsql: Fix pattern matching logic for logs in TAP tests of pgbench
List pgsql-committers
On Thu, Jun 24, 2021 at 10:26:18PM -0400, Andrew Dunstan wrote:
> Since the file isn't read in using slurp_file, that $ won't match
> because the lines will end \r\n instead of \n.

I did not remember this one with Msys, thanks.  I am not sure that
there is any need for an eval block here actually once you remove
open()?  What do you think about something like the attached?
--
Michael

Attachment

pgsql-committers by date:

Previous
From: Amit Kapila
Date:
Subject: pgsql: Doc: Fix minor formatting issue in logicaldecoding.sgml.
Next
From: Peter Eisentraut
Date:
Subject: pgsql: Remove redundant variable pageSize in gistinitpage