Re: pgsql: Remove command checks in tests of pg_basebackup and pg_receivewa - Mailing list pgsql-committers

From Michael Paquier
Subject Re: pgsql: Remove command checks in tests of pg_basebackup and pg_receivewa
Date
Msg-id Ynm4ecSwODdS23EA@paquier.xyz
Whole thread Raw
In response to Re: pgsql: Remove command checks in tests of pg_basebackup and pg_receivewa  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: pgsql: Remove command checks in tests of pg_basebackup and pg_receivewa
List pgsql-committers
On Mon, May 09, 2022 at 10:10:27AM -0400, Andrew Dunstan wrote:
> The system() call should include redirection, since we only case about
> the return code.

Okay, done using File::Spec::devnull.

> I would just write this
>
> as
>
>     $ENV{$envname} = $envdefault if $rc == 0;
>
> There should be no need to set it to the empty string in case if
> failure, we already know it's undefined.

This needs to be adjusted on all the stable branches, so I'll do that
once this week's version is tagged.  Attached is an updated patch for
now.
--
Michael

Attachment

pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Stamp 10.21.
Next
From: Michael Paquier
Date:
Subject: pgsql: Fix several issues with the TAP tests of pg_upgrade