Request a Demo
Home   >   mailing lists

Re: convert libpgport's pqsignal() to a void function - Mailing list pgsql-hackers

From Nathan Bossart
Subject Re: convert libpgport's pqsignal() to a void function
Date
Msg-id Z4cyRX-hqfXREYKC@nathan
Whole thread Raw
In response to Re: convert libpgport's pqsignal() to a void function  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: convert libpgport's pqsignal() to a void function
List pgsql-hackers
Tree view 
On Tue, Jan 14, 2025 at 10:02:46PM -0500, Tom Lane wrote:
> LGTM, although I don't know enough about Windows to know if the
> "== SIG_ERR" test in that path is correct.

It's apparently not [0].  :(

My guess is that this has something to do with redefining SIG_ERR in
win32_port.h.  We might be able to use push_macro/pop_macro to keep the old
value around, but at the moment I'm leaning towards just removing the
assertion in that path.

[0] https://cirrus-ci.com/task/6237809813487616

-- 
nathan

pgsql-hackers by date:

Previous
From: vignesh C
Date:
Subject: Re: Introduce XID age and inactive timeout based replication slot invalidation
Next
From: Tom Lane
Date:
Subject: Re: convert libpgport's pqsignal() to a void function