Postgres Pro
Downloads
Home   >   mailing lists

ObjectIdGetDatum() missing from SearchSysCache*() callers - Mailing list pgsql-hackers

From Michael Paquier
Subject ObjectIdGetDatum() missing from SearchSysCache*() callers
Date
Msg-id ZLUhqsqQN1MOaxdw@paquier.xyz
Whole thread Raw
Responses Re: ObjectIdGetDatum() missing from SearchSysCache*() callers
Re: ObjectIdGetDatum() missing from SearchSysCache*() callers
List pgsql-hackers
Tree view 
Hi all,

While scanning the code, I have noticed that a couple of code paths
that do syscache lookups are passing down directly Oids rather than
Datums.  I think that we'd better be consistent here, even if there is
no actual bug.

I have noticed 11 callers of SearchSysCache*() that pass down
an Oid instead of a Datum.

Thoughts or comments?
--
Michael
Attachment

pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: doc: clarify the limitation for logical replication when REPILICA IDENTITY is FULL
Next
From: Aleksander Alekseev
Date:
Subject: Re: Make mesage at end-of-recovery less scary.