Re: pg_basebackup: errors on macOS on directories with ".DS_Store" files - Mailing list pgsql-bugs

From Michael Paquier
Subject Re: pg_basebackup: errors on macOS on directories with ".DS_Store" files
Date
Msg-id ZLnI3vLFVnpXj0sE@paquier.xyz
Whole thread Raw
In response to Re: pg_basebackup: errors on macOS on directories with ".DS_Store" files  (Daniel Gustafsson <daniel@yesql.se>)
Responses Re: pg_basebackup: errors on macOS on directories with ".DS_Store" files
List pgsql-bugs
On Thu, Jul 20, 2023 at 12:36:52PM +0200, Daniel Gustafsson wrote:
> On 20 Jul 2023, at 09:47, Michael Paquier <michael@paquier.xyz> wrote:
>> Hmm.  Are you sure that this is correct for pg_rewind?  This should
>> work when using a local source with --source-pgdata, but under a
>> remote source with --source-pgdata, I get the impression that we'd
>> still copy a .DS_store into the target's data folder.
>
> Ah, good point.  The updated patch should work for both by moving the check
> into the filemap.

Sounds OK to me to do that in the filemap.  The checksum and base
backup parts look OK as well.  Thanks for the quick update!
--
Michael

Attachment

pgsql-bugs by date:

Previous
From: Andres Martin del Campo Campos
Date:
Subject: Re: BUG #18027: Logical replication taking forever
Next
From: Masahiko Sawada
Date:
Subject: Re: BUG #18031: Segmentation fault after deadlock within VACUUM's parallel worker