Postgres Pro
Downloads
Home   >   mailing lists

Re: Wrong usage of pqMsg_Close message code? - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Wrong usage of pqMsg_Close message code?
Date
Msg-id ZO0lcXlwln/Ir09S@paquier.xyz
Whole thread Raw
In response to Re: Wrong usage of pqMsg_Close message code?  (Tatsuo Ishii <ishii@sraoss.co.jp>)
Responses Re: Wrong usage of pqMsg_Close message code?
List pgsql-hackers
Tree view 
On Tue, Aug 29, 2023 at 06:12:00AM +0900, Tatsuo Ishii wrote:
> I think EndReplicationCommand needs to be fixed as well.

Yeah, both of you are right here.  Anyway, it seems to me that there
is a bit more going on in protocol.h.  I have noticed two more things
that are incorrect:
- HandleParallelMessage is missing a message for 'P', but I think that
we should have a code for it as well as part of the parallel query
protocol.
- PqMsg_Terminate can be sent by the frontend *and* the backend, see
fe-connect.c and parallel.c.  However, protocol.h documents it as a
frontend-only code.
--
Michael
Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: [PATCH v1] PQputCopyEnd never returns 0, fix the inaccurate comment
Next
From: Bruce Momjian
Date:
Subject: Re: Debian 12 gcc warning