Re: Partitioned tables and [un]loggedness - Mailing list pgsql-hackers

From Nathan Bossart
Subject Re: Partitioned tables and [un]loggedness
Date
Msg-id aEBxIcAiiDVlQvdx@nathan
Whole thread Raw
In response to Re: Partitioned tables and [un]loggedness  (Shinya Kato <shinya11.kato@gmail.com>)
Responses Re: Partitioned tables and [un]loggedness
List pgsql-hackers
On Wed, Jun 04, 2025 at 07:05:20PM +0900, Shinya Kato wrote:
> On Wed, Jun 4, 2025 at 6:55 PM Shinya Kato <shinya11.kato@gmail.com> wrote:
>> Should we consider preventing tab completion for PARTITION BY
>> immediately after CREATE TABLE name (...)? Or is it fine to leave it
>> as is, given that it's syntactically correct?
> 
> Sorry.
> CREATE TABLE name (...) -> CREATE UNLOGGED TABLE name (...)

I see no benefit in recommending things that are guaranteed to error.  In
commit 5c1ce1b, we removed tab completion for CREATE UNLOGGED MATERIALIZED
VIEW even though it is supported by the grammar.  The partitioned table
case sounds like roughly the same situation.

-- 
nathan



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: ABI Compliance Checker GSoC Project
Next
From: Nathan Bossart
Date:
Subject: Re: like pg_shmem_allocations, but fine-grained for DSM registry ?