Re: BUG #19093: Behavioral change in walreceiver termination between PostgreSQL 14.17 and 14.18 - Mailing list pgsql-bugs

From Michael Paquier
Subject Re: BUG #19093: Behavioral change in walreceiver termination between PostgreSQL 14.17 and 14.18
Date
Msg-id aQQqBUuRAS38u3w8@paquier.xyz
Whole thread Raw
In response to Re: BUG #19093: Behavioral change in walreceiver termination between PostgreSQL 14.17 and 14.18  (Xuneng Zhou <xunengzhou@gmail.com>)
Responses Re: BUG #19093: Behavioral change in walreceiver termination between PostgreSQL 14.17 and 14.18
List pgsql-bugs
On Fri, Oct 31, 2025 at 12:07:01AM +0800, Xuneng Zhou wrote:
> Using a wrapper function seems better here.

For a cleaner git history, the wrapper function and the assertion
should be split as its own commit, with the actual fix applied first.
Just an opinion.

> I’ve incorporated both tests and the assertion into the patch applied to master.
> For earlier stable branches, the test in
> 040_standby_failover_slots_sync.pl and the assertion for
> WAL receiver state checking are not included (if Noah agrees too). Please check.

Thanks for doing that.  I have extracted the test to check the "valid"
WAL receiver shutdown case, and applied that separately.

Noah, what do you think?
--
Michael

Attachment

pgsql-bugs by date:

Previous
From: David Rowley
Date:
Subject: Re: BUG #19099: Conditional DELETE from partitioned table with non-updatable partition raises internal error
Next
From: "dengkai"
Date:
Subject: [bug report] About create table like feature's bug