Re: BUG #19093: Behavioral change in walreceiver termination between PostgreSQL 14.17 and 14.18 - Mailing list pgsql-bugs

Hi,

On Fri, Oct 31, 2025 at 11:16 AM Michael Paquier <michael@paquier.xyz> wrote:
>
> On Fri, Oct 31, 2025 at 12:07:01AM +0800, Xuneng Zhou wrote:
> > Using a wrapper function seems better here.
>
> For a cleaner git history, the wrapper function and the assertion
> should be split as its own commit, with the actual fix applied first.
> Just an opinion.
>

It makes sense to me. I've split the patch for HEAD into three patch
sets.  Please see the attached files.

> > I’ve incorporated both tests and the assertion into the patch applied to master.
> > For earlier stable branches, the test in
> > 040_standby_failover_slots_sync.pl and the assertion for
> > WAL receiver state checking are not included (if Noah agrees too). Please check.
>
> Thanks for doing that.  I have extracted the test to check the "valid"
> WAL receiver shutdown case, and applied that separately.

Thanks for checking and pushing this.

Best,
Xuneng