Re: Missing free_var() at end of accum_sum_final()? - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Missing free_var() at end of accum_sum_final()?
Date
Msg-id b294c65f-1494-11b7-d7af-966ced5de6b7@eisentraut.org
Whole thread Raw
In response to Re: Missing free_var() at end of accum_sum_final()?  ("Joel Jacobson" <joel@compiler.org>)
List pgsql-hackers
On 05.03.23 09:53, Joel Jacobson wrote:
> On Fri, Mar 3, 2023, at 16:11, Dean Rasheed wrote:
>> Attachments:
>> * make-result-using-vars-buf-v2.patch
> 
> One suggestion: maybe add a comment explaining why the allocated buffer
> which size is based on strlen(cp) for the decimal digit values,
> is guaranteed to be large enough also for the result's digit buffer?
> 
> I.e. some kind of proof why
> 
>     (NUMERIC_HDRSZ + strlen(cp) + DEC_DIGITS * 2) >= ((ndigits + 1) * sizeof(NumericDigit)))
> 
> holds true in general.

It looks like this thread has fizzled out, and no one is really working 
on the various proposed patch variants.  Unless someone indicates that 
they are still seriously pursuing this, I will mark this patch as 
"Returned with feedback".




pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: pg_upgrade and logical replication
Next
From: Michael Paquier
Date:
Subject: Re: Unlogged relation copy is not fsync'd