Re: meson's in-tree libpq header search order vs -Dextra_include_dirs - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: meson's in-tree libpq header search order vs -Dextra_include_dirs
Date
Msg-id b3796a7b-8f78-4a2d-ba74-24e00f2ca71e@iki.fi
Whole thread Raw
In response to Re: meson's in-tree libpq header search order vs -Dextra_include_dirs  (Thomas Munro <thomas.munro@gmail.com>)
Responses Re: meson's in-tree libpq header search order vs -Dextra_include_dirs
Re: meson's in-tree libpq header search order vs -Dextra_include_dirs
List pgsql-hackers
On 14/09/2025 06:23, Thomas Munro wrote:
> Added to commitfest: https://commitfest.postgresql.org/patch/6056/
> 
> I'm having to carry this patch in all my development branches for now
> or I can't build on one of my regular dev machines, so I'm quite keen
> to get this into the tree soon and would back-patch to 16.
> 
> I gather no one else is affected yet, but I assume you can see the
> problem on a Mac by installing PostgreSQL with Homebrew/MacPorts, or
> on CI if you do this to .cirrus.tasks.yml:
> 
>     setup_additional_packages_script: |
> -    #pkg install -y ...
> +    pkg install -y postgresql17-client

The patch seems harmless enough to me, no objections to committing it. 
However, I'm worried that we'll soon break it again. The new rule is 
apparently "include libpq first", but we have no way of enforcing it.

- Heikki




pgsql-hackers by date:

Previous
From: Andrey Borodin
Date:
Subject: Re: [PATCH] Add archive_mode=follow_primary to prevent unarchived WAL on standby promotion
Next
From: Robert Haas
Date:
Subject: Re: apply_scanjoin_target_to_paths and partitionwise join