Postgres Pro
Downloads
Home   >   mailing lists

Re: Use function smgrclose() to replace the loop - Mailing list pgsql-hackers

From Ilia Evdokimov
Subject Re: Use function smgrclose() to replace the loop
Date
Msg-id b4da130f-35ae-4506-b6f5-b904b7cfe20a@tantorlabs.com
Whole thread Raw
In response to Use function smgrclose() to replace the loop  (Steven Niu <niushiji@gmail.com>)
Responses Re: Use function smgrclose() to replace the loop
List pgsql-hackers
Tree view 
On 14.08.2024 09:32, Steven Niu wrote:
> Hi, Kirill, Junwang,
>
> I made this patch to address the refactor issue in our previous email 
> discussion.
> https://www.postgresql.org/message-id/flat/CABBtG=cDTCBDCBK7McSy6bJR3s5xUTOg0vSFfuW8oLdUYyCscA@mail.gmail.com 
>
>
> That is, the for loop in function smgrdestroy() and smgrdounlinkall 
> can be replaced with smgrclose().
>
> for (forknum = 0; forknum <= MAX_FORKNUM; forknum++)
>     smgrsw[reln->smgr_which].smgr_close(reln, forknum);
> -->
> smgrclose(rels[i]);
>
> Please let me know if you have any questions.
>
> Best Regards,
> Steven from Highgo.com

Hello,

Are you sure we can refactor loop by 'smgrclose()'? I see it is not 
quite the same.

Regards,
Ilia Evdokimov,
Tantor Labs LLC.

pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: Missing deconstruct_array_builtin usage
Next
From: Denis Garsh
Date:
Subject: Re: Add system column support to the USING clause