Re: pgsql: pg_createsubscriber: Fix error complaining about the wrong thing - Mailing list pgsql-committers

From Peter Eisentraut
Subject Re: pgsql: pg_createsubscriber: Fix error complaining about the wrong thing
Date
Msg-id cd594df7-e677-4e35-9a28-e9e929110339@eisentraut.org
Whole thread Raw
In response to Re: pgsql: pg_createsubscriber: Fix error complaining about the wrong thing  (Peter Eisentraut <peter@eisentraut.org>)
Responses Re: pgsql: pg_createsubscriber: Fix error complaining about the wrong thing
List pgsql-committers
On 04.11.25 11:40, Peter Eisentraut wrote:
> On 31.10.25 18:08, Álvaro Herrera wrote:
>> pg_createsubscriber: Fix error complaining about the wrong thing
>>
>> The code updates the system identifier, then runs pg_walreset; if the
>> latter fails, it complains about the former, which makes no sense.
>> Change the error message to complain about the right thing.
> 
> - pg_log_info("subscriber successfully changed the system identifier");
> + pg_log_info("subscriber successfully reset WAL on the subscriber");
> 
> Maybe that message has one "subscriber" too many?

I have fixed this.




pgsql-committers by date:

Previous
From: John Naylor
Date:
Subject: pgsql: Cosmetic fixes in GiST README
Next
From: Peter Eisentraut
Date:
Subject: pgsql: Fix redundancy in error message