Re: pgsql: pg_createsubscriber: Fix error complaining about the wrong thing - Mailing list pgsql-committers

From Peter Eisentraut
Subject Re: pgsql: pg_createsubscriber: Fix error complaining about the wrong thing
Date
Msg-id e6129aad-0085-4bc3-8b5f-63fbee7b488a@eisentraut.org
Whole thread Raw
In response to pgsql: pg_createsubscriber: Fix error complaining about the wrong thing  (Álvaro Herrera <alvherre@kurilemu.de>)
Responses Re: pgsql: pg_createsubscriber: Fix error complaining about the wrong thing
List pgsql-committers
On 31.10.25 18:08, Álvaro Herrera wrote:
> pg_createsubscriber: Fix error complaining about the wrong thing
> 
> The code updates the system identifier, then runs pg_walreset; if the
> latter fails, it complains about the former, which makes no sense.
> Change the error message to complain about the right thing.

- pg_log_info("subscriber successfully changed the system identifier");
+ pg_log_info("subscriber successfully reset WAL on the subscriber");

Maybe that message has one "subscriber" too many?




pgsql-committers by date:

Previous
From: Álvaro Herrera
Date:
Subject: pgsql: Use USECS_PER_SEC from datatype/timestamp.h
Next
From: Michael Paquier
Date:
Subject: pgsql: libpq: Improve error handling in passwordFromFile()