Thread: Dialogs review
Hi all, I'm thinking about doing a complete review of our dialogs. During my work on the comment tab, I found many dialogs not using spacers and sizers. So, I would like to add them and, if at all possible, make dialogs growable. Of course, I'll wait the comment patch is applied before working on this. There's a question left to me. Should I do a complete review and send a complete patch, or should I send one patch for each dialog? A complete patch will be really hard to review. Having one patch for each dialog will be simple to review but the number of patches needed will be a major burden. I tend to prefer the "one patch for each dialog" approach, but I would like to know your thoughts on this. -- Guillaume. http://www.postgresqlfr.org http://dalibo.com
Guillaume Lelarge wrote: > Hi all, > > I'm thinking about doing a complete review of our dialogs. During my > work on the comment tab, I found many dialogs not using spacers and > sizers. So, I would like to add them and, if at all possible, make > dialogs growable. Of course, I'll wait the comment patch is applied > before working on this. > > There's a question left to me. Should I do a complete review and send a > complete patch, or should I send one patch for each dialog? A complete > patch will be really hard to review. Having one patch for each dialog > will be simple to review but the number of patches needed will be a > major burden. > > I tend to prefer the "one patch for each dialog" approach, but I would > like to know your thoughts on this. Personally, I prefer one per dialog, for the reasons you state above. //Magnus
On Sun, Jun 15, 2008 at 8:21 AM, Guillaume Lelarge <guillaume@lelarge.info> wrote: > Hi all, > > I'm thinking about doing a complete review of our dialogs. During my work on > the comment tab, I found many dialogs not using spacers and sizers. So, I > would like to add them and, if at all possible, make dialogs growable. Of > course, I'll wait the comment patch is applied before working on this. OK. One thought I had - XRCed doesn't do a great job as we already know. If you're going to review the dialogues to this level, please consider other tools such as DialogBlocks - they may do a far better job of automating the process, and have a distinct style in the way they handle layout (preferring one sizer type over another for example). Let's take the opportunity to review the tools and pick something that will make this nice and easy in the future. Oh, and just so you know, some of the tools out there are not Open Source. pgAdmin is not a political project, and I wouldn't want us to discount something that may be a great tool purely because it's not OSS. Obviously if it costs money, then that is an issue. > There's a question left to me. Should I do a complete review and send a > complete patch, or should I send one patch for each dialog? A complete patch > will be really hard to review. Having one patch for each dialog will be > simple to review but the number of patches needed will be a major burden. Incremental patching is fine. It's easier for everyone in the long run. -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com
Dave Page a écrit : > On Sun, Jun 15, 2008 at 8:21 AM, Guillaume Lelarge > <guillaume@lelarge.info> wrote: >> >> I'm thinking about doing a complete review of our dialogs. During my work on >> the comment tab, I found many dialogs not using spacers and sizers. So, I >> would like to add them and, if at all possible, make dialogs growable. Of >> course, I'll wait the comment patch is applied before working on this. > > OK. One thought I had - XRCed doesn't do a great job as we already > know. If you're going to review the dialogues to this level, please > consider other tools such as DialogBlocks - they may do a far better > job of automating the process, and have a distinct style in the way > they handle layout (preferring one sizer type over another for > example). Let's take the opportunity to review the tools and pick > something that will make this nice and easy in the future. > I downloaded it. I'll try to work with it on one dialog and see how it goes. > Oh, and just so you know, some of the tools out there are not Open > Source. pgAdmin is not a political project, and I wouldn't want us to > discount something that may be a great tool purely because it's not > OSS. Obviously if it costs money, then that is an issue. > It costs 56 €. >> There's a question left to me. Should I do a complete review and send a >> complete patch, or should I send one patch for each dialog? A complete patch >> will be really hard to review. Having one patch for each dialog will be >> simple to review but the number of patches needed will be a major burden. > > Incremental patching is fine. It's easier for everyone in the long run. > Yeah, that's what I think. -- Guillaume. http://www.postgresqlfr.org http://dalibo.com
On Mon, Jun 16, 2008 at 8:52 AM, Guillaume Lelarge <guillaume@lelarge.info> wrote: >> Oh, and just so you know, some of the tools out there are not Open >> Source. pgAdmin is not a political project, and I wouldn't want us to >> discount something that may be a great tool purely because it's not >> OSS. Obviously if it costs money, then that is an issue. >> > > It costs 56 €. That is an issue (well, it's not for me, and I suppose as long as it still creates XRC files, then other people could use XRCed or whatever). In any case, if you're doing the major overhaul, it's important to choose a tool you're happy with. It would probably be worth looking at the wxCommunity site - there are more tools listed there: http://www.wxcommunity.com/modules.php?op=modload&name=Downloads&file=index&req=viewsdownload&sid=4 -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com
Guillaume Lelarge a écrit : > [...] > I tend to prefer the "one patch for each dialog" approach, but I would > like to know your thoughts on this. > Here is the first one, dlgAggregate.xrc. -- Guillaume. http://www.postgresqlfr.org http://dalibo.com Index: pgadmin/ui/dlgAggregate.xrc =================================================================== --- pgadmin/ui/dlgAggregate.xrc (revision 7390) +++ pgadmin/ui/dlgAggregate.xrc (working copy) @@ -2,153 +2,297 @@ <resource> <object class="wxDialog" name="dlgAggregate"> <title></title> - <object class="wxNotebook" name="nbNotebook"> - <object class="notebookpage"> - <label>Properties</label> - <object class="wxPanel" name="pnlProperties"> - <object class="wxStaticText" name="stName"> - <label>Name</label> - <pos>5,7d</pos> + <size>218,238d</size> + <style>wxDEFAULT_DIALOG_STYLE|wxCAPTION|wxSYSTEM_MENU|wxRESIZE_BORDER|wxRESIZE_BOX|wxTHICK_FRAME</style> + <object class="wxFlexGridSizer"> + <cols>1</cols> + <object class="sizeritem"> + <object class="wxNotebook" name="nbNotebook"> + <object class="notebookpage"> + <label>Properties</label> + <object class="wxPanel" name="pnlProperties"> + <object class="wxFlexGridSizer"> + <cols>2</cols> + <rows>5</rows> + <vgap>5</vgap> + <hgap>5</hgap> + <growablerows>3</growablerows> + <growablecols>1</growablecols> + <object class="sizeritem"> + <object class="wxStaticText" name="stName"> + <label>Name</label> + <pos>5,7d</pos> + </object> + <flag>wxALIGN_CENTRE_VERTICAL</flag> + </object> + <object class="sizeritem"> + <object class="wxTextCtrl" name="txtName"> + <pos>70,5d</pos> + <size>135,-1d</size> + </object> + <flag>wxEXPAND|wxALIGN_TOP</flag> + </object> + <object class="sizeritem"> + <object class="wxStaticText" name="stOID"> + <label>OID</label> + <pos>5,22d</pos> + </object> + <flag>wxALIGN_CENTRE_VERTICAL</flag> + </object> + <object class="sizeritem"> + <object class="wxTextCtrl" name="txtOID"> + <pos>70,20d</pos> + <size>135,-1d</size> + </object> + <flag>wxEXPAND|wxALIGN_CENTRE_VERTICAL</flag> + </object> + <object class="sizeritem"> + <object class="wxStaticText" name="stOwner"> + <label>Owner</label> + <pos>5,37d</pos> + </object> + <flag>wxALIGN_CENTRE_VERTICAL</flag> + </object> + <object class="sizeritem"> + <object class="ctlComboBox" name="cbOwner"> + <pos>70,35d</pos> + <size>135,12d</size> + <content/> + <style>wxCB_DROPDOWN</style> + </object> + <flag>wxEXPAND|wxALIGN_CENTRE_VERTICAL</flag> + </object> + <object class="sizeritem"> + <object class="wxStaticText" name="stComment"> + <label>Comment</label> + <pos>5,52d</pos> + </object> + <flag>wxALIGN_CENTRE_VERTICAL</flag> + </object> + <object class="sizeritem"> + <object class="wxTextCtrl" name="txtComment"> + <pos>70,50d</pos> + <size>135,132d</size> + <style>wxTE_MULTILINE</style> + </object> + <flag>wxALL|wxEXPAND</flag> + </object> + <object class="sizeritem"> + <object class="wxStaticText" name="stClusterSet"> + <label>Use replication</label> + <pos>5,187d</pos> + </object> + <flag>wxALIGN_CENTRE_VERTICAL</flag> + </object> + <object class="sizeritem"> + <object class="wxComboBox" name="cbClusterSet"> + <content/> + <pos>70,185d</pos> + <size>135,12d</size> + <style>wxCB_READONLY|wxCB_DROPDOWN</style> + </object> + <flag>wxEXPAND|wxALIGN_CENTRE_VERTICAL</flag> + </object> + </object> + </object> </object> - <object class="wxTextCtrl" name="txtName"> - <pos>70,5d</pos> - <size>135,-1d</size> + <object class="notebookpage"> + <label>Definition</label> + <object class="wxPanel" name="pnlDefinition"> + <object class="wxFlexGridSizer"> + <cols>2</cols> + <rows>7</rows> + <vgap>5</vgap> + <hgap>5</hgap> + <growablecols>1</growablecols> + <growablerows>0</growablerows> + <object class="sizeritem"> + <object class="wxFlexGridSizer"> + <cols>1</cols> + <rows>2</rows> + <vgap>5</vgap> + <hgap>5</hgap> + <growablerows>1</growablerows> + <object class="sizeritem"> + <object class="wxStaticText" name="stInputTypes"> + <label>Input types</label> + <pos>5,7d</pos> + </object> + <flag>wxALIGN_CENTRE_VERTICAL</flag> + </object> + <object class="sizeritem"> + <object class="wxButton" name="btnRemoveType"> + <label>&Remove</label> + <pos>5,87d</pos> + <size>60,-1d</size> + </object> + <flag>wxALIGN_BOTTOM|wxBOTTOM</flag> + </object> + </object> + </object> + <object class="sizeritem"> + <object class="wxListCtrl" name="lstInputTypes"> + <pos>70,5d</pos> + <size>135,97d</size> + <style>wxLC_REPORT</style> + </object> + <flag>wxALL|wxEXPAND</flag> + </object> + <object class="sizeritem"> + <object class="wxButton" name="btnAddType"> + <label>&Add</label> + <pos>5,105d</pos> + <size>60,-1d</size> + </object> + <flag>wxALIGN_CENTRE_VERTICAL</flag> + </object> + <object class="sizeritem"> + <object class="ctlComboBox" name="cbInputType"> + <content/> + <pos>70,105d</pos> + <size>135,12d</size> + <style>wxCB_DROPDOWN</style> + </object> + <flag>wxEXPAND|wxALIGN_CENTRE_VERTICAL</flag> + </object> + <object class="sizeritem"> + <object class="wxStaticText" name="stStateType"> + <label>State type</label> + <pos>5,127d</pos> + </object> + <flag>wxALIGN_CENTRE_VERTICAL</flag> + </object> + <object class="sizeritem"> + <object class="ctlComboBox" name="cbStateType"> + <content/> + <pos>70,125d</pos> + <size>135,12d</size> + <style>wxCB_DROPDOWN</style> + </object> + <flag>wxEXPAND|wxALIGN_CENTRE_VERTICAL</flag> + </object> + <object class="sizeritem"> + <object class="wxStaticText" name="stStateFunc"> + <label>State function</label> + <pos>5,142d</pos> + </object> + <flag>wxALIGN_CENTRE_VERTICAL</flag> + </object> + <object class="sizeritem"> + <object class="wxComboBox" name="cbStateFunc"> + <content/> + <pos>70,140d</pos> + <size>135,12d</size> + <style>wxCB_READONLY|wxCB_DROPDOWN</style> + </object> + <flag>wxEXPAND|wxALIGN_CENTRE_VERTICAL</flag> + </object> + <object class="sizeritem"> + <object class="wxStaticText" name="stFinalFunc"> + <label>Final function</label> + <pos>5,157d</pos> + </object> + <flag>wxALIGN_CENTRE_VERTICAL</flag> + </object> + <object class="sizeritem"> + <object class="wxComboBox" name="cbFinalFunc"> + <content/> + <pos>70,155d</pos> + <size>135,12d</size> + <style>wxCB_READONLY|wxCB_DROPDOWN</style> + </object> + <flag>wxEXPAND|wxALIGN_CENTRE_VERTICAL</flag> + </object> + <object class="sizeritem"> + <object class="wxStaticText" name="stSortOp"> + <label>Sort Operator</label> + <pos>5,172d</pos> + </object> + <flag>wxALIGN_CENTRE_VERTICAL</flag> + </object> + <object class="sizeritem"> + <object class="wxComboBox" name="cbSortOp"> + <content/> + <pos>70,170d</pos> + <size>135,12d</size> + <style>wxCB_READONLY|wxCB_DROPDOWN</style> + </object> + <flag>wxEXPAND|wxALIGN_CENTRE_VERTICAL</flag> + </object> + <object class="sizeritem"> + <object class="wxStaticText" name="stInitial"> + <label>Initial condition</label> + <pos>5,187d</pos> + </object> + <flag>wxALIGN_CENTRE_VERTICAL</flag> + </object> + <object class="sizeritem"> + <object class="wxTextCtrl" name="txtInitial"> + <pos>70,185d</pos> + <size>135,-1d</size> + </object> + <flag>wxEXPAND|wxALIGN_CENTRE_VERTICAL</flag> + </object> + </object> + </object> </object> - <object class="wxStaticText" name="stOID"> - <label>OID</label> - <pos>5,22d</pos> - </object> - <object class="wxTextCtrl" name="txtOID"> - <pos>70,20d</pos> - <size>135,-1d</size> - </object> - <object class="wxStaticText" name="stOwner"> - <label>Owner</label> - <pos>5,37d</pos> - </object> - <object class="ctlComboBox" name="cbOwner"> - <pos>70,35d</pos> - <size>135,12d</size> - <content/> - <style>wxCB_DROPDOWN</style> - </object> - <object class="wxStaticText" name="stComment"> - <label>Comment</label> - <pos>5,52d</pos> - </object> - <object class="wxTextCtrl" name="txtComment"> - <pos>70,50d</pos> - <size>135,132d</size> - <style>wxTE_MULTILINE</style> - </object> - <object class="wxStaticText" name="stClusterSet"> - <label>Use replication</label> - <pos>5,187d</pos> - </object> - <object class="wxComboBox" name="cbClusterSet"> - <content/> - <pos>70,185d</pos> - <size>135,12d</size> - <style>wxCB_READONLY|wxCB_DROPDOWN</style> - </object> </object> - <selected>1</selected> + <flag>wxALL|wxGROW|wxALIGN_CENTRE</flag> + <border>3</border> </object> - <pos>2,2d</pos> - <size>214,215d</size> - <object class="notebookpage"> - <label>Definition</label> - <object class="wxPanel" name="pnlDefinition"> - <object class="wxStaticText" name="stInputTypes"> - <label>Input types</label> - <pos>5,7d</pos> + <growablecols>0</growablecols> + <growablerows>0</growablerows> + <object class="spacer"> + <size>2,2d</size> + </object> + <object class="sizeritem"> + <object class="wxFlexGridSizer"> + <cols>7</cols> + <object class="spacer"> + <size>3,3d</size> </object> - <object class="wxListCtrl" name="lstInputTypes"> - <pos>70,5d</pos> - <size>135,97d</size> - <style>wxLC_REPORT</style> + <object class="sizeritem"> + <object class="wxButton" name="wxID_HELP"> + <label>Help</label> + <pos>135,220d</pos> + </object> </object> - <object class="wxButton" name="btnRemoveType"> - <label>&Remove</label> - <pos>5,87d</pos> - <size>60,-1d</size> + <object class="spacer"> + <size>3,3d</size> </object> - <object class="wxButton" name="btnAddType"> - <label>&Add</label> - <pos>5,105d</pos> - <size>60,-1d</size> + <object class="sizeritem"> + <object class="wxButton" name="wxID_OK"> + <label>&OK</label> + <default>1</default> + <pos>135,220d</pos> + </object> </object> - <object class="ctlComboBox" name="cbInputType"> - <content/> - <pos>70,105d</pos> - <size>135,12d</size> - <style>wxCB_DROPDOWN</style> + <object class="spacer"> + <size>3,3d</size> </object> - <object class="wxStaticText" name="stStateType"> - <label>State type</label> - <pos>5,127d</pos> + <object class="sizeritem"> + <object class="wxButton" name="wxID_CANCEL"> + <label>&Cancel</label> + <pos>176,220d</pos> + </object> </object> - <object class="ctlComboBox" name="cbStateType"> - <content/> - <pos>70,125d</pos> - <size>135,12d</size> - <style>wxCB_DROPDOWN</style> + <object class="spacer"> + <size>3,3d</size> </object> - <object class="wxStaticText" name="stStateFunc"> - <label>State function</label> - <pos>5,142d</pos> - </object> - <object class="wxComboBox" name="cbStateFunc"> - <content/> - <pos>70,140d</pos> - <size>135,12d</size> - <style>wxCB_READONLY|wxCB_DROPDOWN</style> - </object> - <object class="wxStaticText" name="stFinalFunc"> - <label>Final function</label> - <pos>5,157d</pos> - </object> - <object class="wxComboBox" name="cbFinalFunc"> - <content/> - <pos>70,155d</pos> - <size>135,12d</size> - <style>wxCB_READONLY|wxCB_DROPDOWN</style> - </object> - <object class="wxStaticText" name="stSortOp"> - <label>Sort Operator</label> - <pos>5,172d</pos> - </object> - <object class="wxComboBox" name="cbSortOp"> - <content/> - <pos>70,170d</pos> - <size>135,12d</size> - <style>wxCB_READONLY|wxCB_DROPDOWN</style> - </object> - <object class="wxStaticText" name="stInitial"> - <label>Initial condition</label> - <pos>5,187d</pos> - </object> - <object class="wxTextCtrl" name="txtInitial"> - <pos>70,185d</pos> - <size>135,-1d</size> - </object> + <growablecols>2</growablecols> </object> + <flag>wxTOP|wxLEFT|wxRIGHT|wxGROW</flag> </object> + <object class="spacer"> + <size>3,3d</size> + </object> + <object class="sizeritem"> + <object class="unknown" name="unkStatusBar"> + <size>-1,15d</size> + </object> + <flag>wxGROW|wxALIGN_CENTRE</flag> + <border>3</border> + </object> </object> - <object class="wxButton" name="wxID_HELP"> - <label>Help</label> - <pos>3,221d</pos> - </object> - <object class="wxButton" name="wxID_OK"> - <label>&OK</label> - <default>1</default> - <pos>113,221d</pos> - </object> - <object class="wxButton" name="wxID_CANCEL"> - <label>&Cancel</label> - <pos>166,221d</pos> - </object> - <size>218,240d</size> - <style></style> </object> </resource>
On Wed, Jul 9, 2008 at 10:51 PM, Guillaume Lelarge <guillaume@lelarge.info> wrote: > Guillaume Lelarge a écrit : >> >> [...] >> I tend to prefer the "one patch for each dialog" approach, but I would >> like to know your thoughts on this. >> > > Here is the first one, dlgAggregate.xrc. Cool. Testing on Mac, there are a couple of minor issues. - There needs to be more of a border around the panes and between the contorls. The controls are very tight to the top, bottom and sides of the dialog (to the extend that the "I'm active" glow around controls is cut off on the top and right hand sides for instance. Similar eclipsing can be seen between controls. We probably just need an extra 2d or so everywhere. - When resizing on the definition pane, the height of the list box increases, but doesn't decrease, so if you shrink the dialogue again, the controls at the bottom of the tab get hidden. The same does not happen on the properties page where the comments textbox resizes correctly. Aside from that, it does look good. Resizing of labels in different languages works nicely, and everything looks nice and consistent. Nice work :-) -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com
[Screenshots at http://developer.pgadmin.org/~dpage/Screenshots.zip] On Thu, Jul 10, 2008 at 1:45 PM, Guillaume Lelarge <guillaume@lelarge.info> wrote: > Dave Page a écrit : >> >> - There needs to be more of a border around the panes and between the >> contorls. The controls are very tight to the top, bottom and sides of >> the dialog (to the extend that the "I'm active" glow around controls >> is cut off on the top and right hand sides for instance. Similar >> eclipsing can be seen between controls. We probably just need an extra >> 2d or so everywhere. >> > > Fixed on Linux and Win32. Yup, looks much better on Mac - in fact if anything it's gone a bit too far the other way. Maybe try 1 or 2d less than you've done. The SQL tab still needs similar treatment though. See the screenshots. >> - When resizing on the definition pane, the height of the list box >> increases, but doesn't decrease, so if you shrink the dialogue again, >> the controls at the bottom of the tab get hidden. The same does not >> happen on the properties page where the comments textbox resizes >> correctly. >> > > I don't have the issue, neither on Linux, neither on Win32. Can you check > with this new patch? Thanks. Yes it still occurs :-(. The screenshots show what I mean. >> Aside from that, it does look good. Resizing of labels in different >> languages works nicely, and everything looks nice and consistent. >> >> Nice work :-) >> > > Thanks. But something is bothering me. The status bar on the bottom of the > window doesn't seem to work on Windows, it seems to have disappeared. > dlgFunction seems to suffer the same issue but I didn't work on its xrc > file. And it works on Linux, for each dialog. Can you check on Mac and > Windows? It's there on the Mac (in both dialogs). I can't currently run Windows (other tasks already running in vmware), so cannot test there atm. A new problem on dlgCasts - the source and target type combo boxes are invisible unless I resize(!). I only need to enlarge the dialogue by 1px or so and they both magically appear. I suspect this is unrelated to the actual size, but perhaps we need to kick the sizers after loading the dialogue to force them to resize everything. If memory serves there's a recalculate function. > Sorry for asking you to do so many tests. I really should get a Mac Mini. :-) -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com
Dave Page a écrit : > [Screenshots at http://developer.pgadmin.org/~dpage/Screenshots.zip] > > On Thu, Jul 10, 2008 at 1:45 PM, Guillaume Lelarge > <guillaume@lelarge.info> wrote: >> Dave Page a écrit : >>> - There needs to be more of a border around the panes and between the >>> contorls. The controls are very tight to the top, bottom and sides of >>> the dialog (to the extend that the "I'm active" glow around controls >>> is cut off on the top and right hand sides for instance. Similar >>> eclipsing can be seen between controls. We probably just need an extra >>> 2d or so everywhere. >>> >> Fixed on Linux and Win32. > > Yup, looks much better on Mac - in fact if anything it's gone a bit > too far the other way. Maybe try 1 or 2d less than you've done. The > SQL tab still needs similar treatment though. > > See the screenshots. > Fixed. >>> - When resizing on the definition pane, the height of the list box >>> increases, but doesn't decrease, so if you shrink the dialogue again, >>> the controls at the bottom of the tab get hidden. The same does not >>> happen on the properties page where the comments textbox resizes >>> correctly. >>> >> I don't have the issue, neither on Linux, neither on Win32. Can you check >> with this new patch? Thanks. > > Yes it still occurs :-(. The screenshots show what I mean. > Hmmmm, I see... that I can't do anything till I get my Mac. I will work on it but I don't know now how to fix it. >>> Aside from that, it does look good. Resizing of labels in different >>> languages works nicely, and everything looks nice and consistent. >>> >>> Nice work :-) >>> >> Thanks. But something is bothering me. The status bar on the bottom of the >> window doesn't seem to work on Windows, it seems to have disappeared. >> dlgFunction seems to suffer the same issue but I didn't work on its xrc >> file. And it works on Linux, for each dialog. Can you check on Mac and >> Windows? > > It's there on the Mac (in both dialogs). I can't currently run Windows > (other tasks already running in vmware), so cannot test there atm. > > A new problem on dlgCasts - the source and target type combo boxes are > invisible unless I resize(!). I only need to enlarge the dialogue by > 1px or so and they both magically appear. I suspect this is unrelated > to the actual size, but perhaps we need to kick the sizers after > loading the dialogue to force them to resize everything. If memory > serves there's a recalculate function. > OK, I will write a new patch for each of them as soon as I can work on the mac mini (but first I need to buy it). -- Guillaume. http://www.postgresqlfr.org http://dalibo.com
On Mon, Jul 14, 2008 at 8:17 PM, Guillaume Lelarge <guillaume@lelarge.info> wrote: > Hmmmm, I see... that I can't do anything till I get my Mac. I will work on > it but I don't know now how to fix it. Understood. I'm really busy right now (yeah, I know I'm starting to sound like a broken record with that one!) but if you send over the latest version of the patch sometime I'll try out a couple of ideas for this and the combo box thing when I can get five minutes.. Cheers, Dave. -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com
Dave Page a écrit : > On Mon, Jul 14, 2008 at 8:17 PM, Guillaume Lelarge > <guillaume@lelarge.info> wrote: > >> Hmmmm, I see... that I can't do anything till I get my Mac. I will work on >> it but I don't know now how to fix it. > > Understood. I'm really busy right now (yeah, I know I'm starting to > sound like a broken record with that one!) but if you send over the > latest version of the patch sometime I'll try out a couple of ideas > for this and the combo box thing when I can get five minutes.. > :) Now that I have a MacMini, that I'm able to build a pgAdmin3.app file, things should go faster and with less burden. Or so I hope. BTW, I have the same issue with the two dialogs. I'm statring to work on this. -- Guillaume. http://www.postgresqlfr.org http://dalibo.com
Guillaume Lelarge a écrit : > Dave Page a écrit : >> On Mon, Jul 14, 2008 at 8:17 PM, Guillaume Lelarge >> <guillaume@lelarge.info> wrote: >> >>> Hmmmm, I see... that I can't do anything till I get my Mac. I will >>> work on >>> it but I don't know now how to fix it. >> >> Understood. I'm really busy right now (yeah, I know I'm starting to >> sound like a broken record with that one!) but if you send over the >> latest version of the patch sometime I'll try out a couple of ideas >> for this and the combo box thing when I can get five minutes.. >> > > :) > > Now that I have a MacMini, that I'm able to build a pgAdmin3.app file, > things should go faster and with less burden. Or so I hope. > > BTW, I have the same issue with the two dialogs. I'm statring to work on > this. > Okay... the wxListCtrl resize problem seems to be a wxMac confirmed bug. See http://trac.wxwidgets.org/ticket/4814 bug report for more details. Not sure about what we should do with this... debug the stuff on wxMac source files? or simply put it in the BUGS file and continue the work ? ... hmmm ... (a few moments later) ... I can try to see what's going on between 2.8.6 and 2.8.7 and if 2.8.6 works for us. (again a few moments later) Nope, doesn't work on 2.8.6 and 2.8.0. I added a comment on the trac tricket. Anyways, I attach the new dlgCast.xrc patch file. -- Guillaume. http://www.postgresqlfr.org http://dalibo.com Index: pgadmin/ui/dlgCast.xrc =================================================================== --- pgadmin/ui/dlgCast.xrc (revision 7393) +++ pgadmin/ui/dlgCast.xrc (working copy) @@ -2,147 +2,221 @@ <resource> <object class="wxDialog" name="dlgCast"> <title></title> - <object class="wxNotebook" name="nbNotebook"> - <object class="notebookpage"> - <label>Properties</label> - <object class="wxPanel" name="pnlProperties"> - <object class="wxStaticText" name="stName"> - - <label>Name</label> - - <pos>5,7d</pos> + <style>wxDEFAULT_DIALOG_STYLE|wxCAPTION|wxSYSTEM_MENU|wxRESIZE_BORDER|wxRESIZE_BOX|wxTHICK_FRAME</style> + <object class="wxFlexGridSizer"> + <cols>1</cols> + <object class="sizeritem"> + <object class="wxNotebook" name="nbNotebook"> + <object class="notebookpage"> + <label>Properties</label> + <object class="wxPanel" name="pnlProperties"> + <object class="wxFlexGridSizer"> + <cols>2</cols> + <rows>8</rows> + <vgap>5</vgap> + <hgap>5</hgap> + <growablerows>6</growablerows> + <growablecols>1</growablecols> + <object class="sizeritem"> + <object class="wxStaticText" name="stName"> + <label>Name</label> + <pos>5,7d</pos> + </object> + <flag>wxALIGN_CENTRE_VERTICAL|wxTOP|wxLEFT|wxRIGHT</flag> + <border>8</border> + </object> + <object class="sizeritem"> + <object class="wxTextCtrl" name="txtCastname"> + <pos>70,5d</pos> + <size>135,-1d</size> + </object> + <flag>wxEXPAND|wxALIGN_TOP|wxTOP|wxLEFT|wxRIGHT</flag> + <border>8</border> + </object> + <object class="sizeritem"> + <object class="wxStaticText" name="stOID"> + <label>OID</label> + <pos>5,22d</pos> + </object> + <flag>wxALIGN_CENTRE_VERTICAL|wxTOP|wxLEFT|wxRIGHT</flag> + <border>8</border> + </object> + <object class="sizeritem"> + <object class="wxTextCtrl" name="txtOID"> + <pos>70,20d</pos> + <size>135,-1d</size> + </object> + <flag>wxEXPAND|wxALIGN_TOP|wxTOP|wxLEFT|wxRIGHT</flag> + <border>8</border> + </object> + <object class="sizeritem"> + <object class="wxStaticText" name="stSourceType"> + <label>Source type</label> + <pos>5,37d</pos> + </object> + <flag>wxALIGN_CENTRE_VERTICAL|wxTOP|wxLEFT|wxRIGHT</flag> + <border>8</border> + </object> + <object class="sizeritem"> + <object class="ctlComboBox" name="cbSourceType"> + <content/> + <pos>70,35d</pos> + <size>130,12d</size> + <style>wxCB_DROPDOWN</style> + </object> + <flag>wxEXPAND|wxALIGN_TOP|wxTOP|wxLEFT|wxRIGHT</flag> + <border>8</border> + </object> + <object class="sizeritem"> + <object class="wxStaticText" name="stTargetType"> + <label>Target type</label> + <pos>5,52d</pos> + </object> + <flag>wxALIGN_CENTRE_VERTICAL|wxTOP|wxLEFT|wxRIGHT</flag> + <border>8</border> + </object> + <object class="sizeritem"> + <object class="ctlComboBox" name="cbTargetType"> + <content/> + <pos>70,50d</pos> + <size>130,12d</size> + <style>wxCB_DROPDOWN</style> + </object> + <flag>wxEXPAND|wxALIGN_TOP|wxTOP|wxLEFT|wxRIGHT</flag> + <border>8</border> + </object> + <object class="sizeritem"> + <object class="wxStaticText" name="stFunction"> + <label>Function</label> + <pos>5,67d</pos> + </object> + <flag>wxALIGN_CENTRE_VERTICAL|wxTOP|wxLEFT|wxRIGHT</flag> + <border>8</border> + </object> + <object class="sizeritem"> + <object class="wxComboBox" name="cbFunction"> + <content/> + <pos>70,65d</pos> + <size>135,12d</size> + <style>wxCB_READONLY|wxCB_DROPDOWN</style> + </object> + <flag>wxEXPAND|wxALIGN_TOP|wxTOP|wxLEFT|wxRIGHT</flag> + <border>8</border> + </object> + <object class="sizeritem"> + <object class="wxStaticText" name="stImplicit"> + <label>Implicit</label> + <pos>5,82d</pos> + </object> + <flag>wxALIGN_CENTRE_VERTICAL|wxTOP|wxLEFT|wxRIGHT</flag> + <border>8</border> + </object> + <object class="sizeritem"> + <object class="wxCheckBox" name="chkImplicit"> + <label></label> + <pos>70,80d</pos> + <size>13,12d</size> + </object> + <flag>wxEXPAND|wxALIGN_TOP|wxTOP|wxLEFT|wxRIGHT</flag> + <border>8</border> + </object> + <object class="sizeritem"> + <object class="wxStaticText" name="stComment"> + <label>Comment</label> + <pos>5,97d</pos> + </object> + <flag>wxALIGN_TOP|wxTOP|wxLEFT|wxRIGHT</flag> + <border>8</border> + </object> + <object class="sizeritem"> + <object class="wxTextCtrl" name="txtComment"> + <pos>70,95d</pos> + <size>135,83d</size> + <style>wxTE_MULTILINE</style> + </object> + <flag>wxEXPAND|wxALL</flag> + <border>8</border> + </object> + <object class="sizeritem"> + <object class="wxStaticText" name="stClusterSet"> + <label>Use replication</label> + <pos>5,183d</pos> + </object> + <flag>wxALIGN_CENTRE_VERTICAL</flag> + </object> + <object class="sizeritem"> + <object class="wxComboBox" name="cbClusterSet"> + <content/> + <pos>70,181d</pos> + <size>135,12d</size> + <style>wxCB_READONLY|wxCB_DROPDOWN</style> + </object> + <flag>wxEXPAND|wxALIGN_TOP|wxALL</flag> + <border>8</border> + </object> + </object> + <selected>1</selected> </object> - <object class="wxTextCtrl" name="txtCastname"> - - <pos>70,5d</pos> - - <size>135,-1d</size> + <pos>2,2d</pos> + <size>214,415d</size> + </object> + </object> + <flag>wxALL|wxGROW|wxALIGN_CENTRE</flag> + <border>3</border> + </object> + <growablecols>0</growablecols> + <growablerows>0</growablerows> + <object class="spacer"> + <size>2,2d</size> + </object> + <object class="sizeritem"> + <object class="wxFlexGridSizer"> + <cols>7</cols> + <object class="spacer"> + <size>3,3d</size> </object> - <object class="wxStaticText" name="stOID"> - - <label>OID</label> - - <pos>5,22d</pos> + <object class="sizeritem"> + <object class="wxButton" name="wxID_HELP"> + <label>Help</label> + <pos>135,220d</pos> + </object> </object> - <object class="wxTextCtrl" name="txtOID"> - - <pos>70,20d</pos> - - <size>135,-1d</size> + <object class="spacer"> + <size>3,3d</size> </object> - <object class="wxStaticText" name="stSourceType"> - - <label>Source type</label> - - <pos>5,37d</pos> + <object class="sizeritem"> + <object class="wxButton" name="wxID_OK"> + <label>&OK</label> + <default>1</default> + <pos>135,220d</pos> + </object> </object> - <object class="ctlComboBox" name="cbSourceType"> - - <content/> - - <pos>70,35d</pos> - - <size>135,12d</size> - - <style>wxCB_DROPDOWN</style> + <object class="spacer"> + <size>3,3d</size> </object> - <object class="wxStaticText" name="stTargetType"> - - <label>Target type</label> - - <pos>5,52d</pos> + <object class="sizeritem"> + <object class="wxButton" name="wxID_CANCEL"> + <label>&Cancel</label> + <pos>176,220d</pos> + </object> </object> - <object class="ctlComboBox" name="cbTargetType"> - - <content/> - - <pos>70,50d</pos> - - <size>135,12d</size> - - <style>wxCB_DROPDOWN</style> + <object class="spacer"> + <size>3,3d</size> </object> - <object class="wxStaticText" name="stFunction"> - - <label>Function</label> - - <pos>5,67d</pos> - </object> - <object class="wxComboBox" name="cbFunction"> - - <content/> - - <pos>70,65d</pos> - - <size>135,12d</size> - - <style>wxCB_READONLY|wxCB_DROPDOWN</style> - </object> - <object class="wxStaticText" name="stImplicit"> - - <label>Implicit</label> - - <pos>5,82d</pos> - </object> - <object class="wxCheckBox" name="chkImplicit"> - - <label></label> - - <pos>70,80d</pos> - - <size>13,12d</size> - </object> - <object class="wxStaticText" name="stComment"> - - <label>Comment</label> - - <pos>5,97d</pos> - </object> - <object class="wxTextCtrl" name="txtComment"> - - <pos>70,95d</pos> - - <size>135,83d</size> - - <style>wxTE_MULTILINE</style> - </object> - <object class="wxStaticText" name="stClusterSet"> - <label>Use replication</label> - <pos>5,183d</pos> - </object> - <object class="wxComboBox" name="cbClusterSet"> - <content/> - <pos>70,181d</pos> - <size>135,12d</size> - <style>wxCB_READONLY|wxCB_DROPDOWN</style> - </object> + <growablecols>2</growablecols> </object> - - <selected>1</selected> + <flag>wxTOP|wxLEFT|wxRIGHT|wxGROW</flag> </object> - <pos>2,2d</pos> - <size>214,215d</size> + <object class="spacer"> + <size>3,3d</size> + </object> + <object class="sizeritem"> + <object class="unknown" name="unkStatusBar"> + <size>-1,15d</size> + </object> + <flag>wxGROW|wxALIGN_CENTRE</flag> + <border>3</border> + </object> </object> - <object class="wxButton" name="wxID_HELP"> - - <label>Help</label> - - <pos>2,220d</pos> - </object> - <object class="wxButton" name="wxID_OK"> - - <label>&OK</label> - - <default>1</default> - - <pos>113,220d</pos> - </object> - <object class="wxButton" name="wxID_CANCEL"> - - <label>&Cancel</label> - - <pos>166,220d</pos> - </object> - <size>218,238d</size> </object> </resource>
On Sat, Jul 19, 2008 at 3:50 PM, Guillaume Lelarge <guillaume@lelarge.info> wrote: > Okay... the wxListCtrl resize problem seems to be a wxMac confirmed bug. See > http://trac.wxwidgets.org/ticket/4814 bug report for more details. Not sure > about what we should do with this... debug the stuff on wxMac source files? > or simply put it in the BUGS file and continue the work ? I was trying to come up with a test case for this using the xrc sample app in wxWidgets - however it seems to work fine. I used the changes below - can you see what's different?: *** controls.xrc.orig 2008-07-21 10:04:12.000000000 +0100 --- controls.xrc 2008-07-21 10:16:49.000000000 +0100 *************** *** 591,606 **** <object class="wxPanel" name="listctrl"> <object class="wxFlexGridSizer"> <cols>1</cols> ! <rows>0</rows> <vgap>0</vgap> <hgap>0</hgap> <growablecols>0</growablecols> <growablerows>0</growablerows> <object class="sizeritem"> ! <flag>wxALIGN_CENTER|wxALL</flag> <border>5</border> <object class="wxListCtrl" name="controls_listctrl"> - <size>220,160</size> <style>wxLC_REPORT|wxSUNKEN_BORDER</style> </object> </object> --- 591,605 ---- <object class="wxPanel" name="listctrl"> <object class="wxFlexGridSizer"> <cols>1</cols> ! <rows>1</rows> <vgap>0</vgap> <hgap>0</hgap> <growablecols>0</growablecols> <growablerows>0</growablerows> <object class="sizeritem"> ! <flag>wxGROW|wxEXPAND|wxTOP|wxLEFT|wxRIGHT</flag> <border>5</border> <object class="wxListCtrl" name="controls_listctrl"> <style>wxLC_REPORT|wxSUNKEN_BORDER</style> </object> </object> -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com
On Sat, Jul 19, 2008 at 3:50 PM, Guillaume Lelarge <guillaume@lelarge.info> wrote: > Anyways, I attach the new dlgCast.xrc patch file. That looks pretty sweet, and works well :-). The only thing I note, is that even with a bigger gap between controls, the bottom highlight on the active control (the blue border on OS X) still isn't shown. If that's the case for you as well, then it seems pointless leaving such a large gap. Reducing the borders from 8 to 4 looks better here. Thoughts? Aside from that, I think that one is ready to go - and should set the standard for the following dialogues :-) -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com
Dave Page a écrit : > On Sat, Jul 19, 2008 at 3:50 PM, Guillaume Lelarge > <guillaume@lelarge.info> wrote: > >> Anyways, I attach the new dlgCast.xrc patch file. > > That looks pretty sweet, and works well :-). The only thing I note, is > that even with a bigger gap between controls, the bottom highlight on > the active control (the blue border on OS X) still isn't shown. If > that's the case for you as well, then it seems pointless leaving such > a large gap. Reducing the borders from 8 to 4 looks better here. > Reducing the border works here too. To have the blue border on each side of the control, we need to make the control bigger. For example, cbSourceType and cbTargetType have 12 for width. With 14, they show the bottom highlight. > Thoughts? Aside from that, I think that one is ready to go - and > should set the standard for the following dialogues :-) > There's still one thing that bothers me. The "Use replication" label seems closer to the left side of the window's border. And I need to check the border and width changes on Linux and Windows. -- Guillaume. http://www.postgresqlfr.org http://dalibo.com <?xml version="1.0" encoding="ISO-8859-1"?> <resource> <object class="wxDialog" name="dlgCast"> <title></title> <style>wxDEFAULT_DIALOG_STYLE|wxCAPTION|wxSYSTEM_MENU|wxRESIZE_BORDER|wxRESIZE_BOX|wxTHICK_FRAME</style> <object class="wxFlexGridSizer"> <cols>1</cols> <object class="sizeritem"> <object class="wxNotebook" name="nbNotebook"> <object class="notebookpage"> <label>Properties</label> <object class="wxPanel" name="pnlProperties"> <object class="wxFlexGridSizer"> <cols>2</cols> <rows>8</rows> <vgap>5</vgap> <hgap>5</hgap> <growablerows>6</growablerows> <growablecols>1</growablecols> <object class="sizeritem"> <object class="wxStaticText" name="stName"> <label>Name</label> <pos>5,7d</pos> </object> <flag>wxALIGN_CENTRE_VERTICAL|wxTOP|wxLEFT|wxRIGHT</flag> <border>4</border> </object> <object class="sizeritem"> <object class="wxTextCtrl" name="txtCastname"> <pos>70,5d</pos> <size>135,-1d</size> </object> <flag>wxEXPAND|wxALIGN_TOP|wxTOP|wxLEFT|wxRIGHT</flag> <border>4</border> </object> <object class="sizeritem"> <object class="wxStaticText" name="stOID"> <label>OID</label> <pos>5,22d</pos> </object> <flag>wxALIGN_CENTRE_VERTICAL|wxTOP|wxLEFT|wxRIGHT</flag> <border>4</border> </object> <object class="sizeritem"> <object class="wxTextCtrl" name="txtOID"> <pos>70,20d</pos> <size>135,-1d</size> </object> <flag>wxEXPAND|wxALIGN_TOP|wxTOP|wxLEFT|wxRIGHT</flag> <border>4</border> </object> <object class="sizeritem"> <object class="wxStaticText" name="stSourceType"> <label>Source type</label> <pos>5,37d</pos> </object> <flag>wxALIGN_CENTRE_VERTICAL|wxTOP|wxLEFT|wxRIGHT</flag> <border>4</border> </object> <object class="sizeritem"> <object class="ctlComboBox" name="cbSourceType"> <content/> <pos>70,35d</pos> <size>130,14d</size> <style>wxCB_DROPDOWN</style> </object> <flag>wxEXPAND|wxALIGN_TOP|wxTOP|wxLEFT|wxRIGHT</flag> <border>4</border> </object> <object class="sizeritem"> <object class="wxStaticText" name="stTargetType"> <label>Target type</label> <pos>5,52d</pos> </object> <flag>wxALIGN_CENTRE_VERTICAL|wxTOP|wxLEFT|wxRIGHT</flag> <border>4</border> </object> <object class="sizeritem"> <object class="ctlComboBox" name="cbTargetType"> <content/> <pos>70,50d</pos> <size>130,14d</size> <style>wxCB_DROPDOWN</style> </object> <flag>wxEXPAND|wxALIGN_TOP|wxTOP|wxLEFT|wxRIGHT</flag> <border>4</border> </object> <object class="sizeritem"> <object class="wxStaticText" name="stFunction"> <label>Function</label> <pos>5,67d</pos> </object> <flag>wxALIGN_CENTRE_VERTICAL|wxTOP|wxLEFT|wxRIGHT</flag> <border>4</border> </object> <object class="sizeritem"> <object class="wxComboBox" name="cbFunction"> <content/> <pos>70,65d</pos> <size>135,12d</size> <style>wxCB_READONLY|wxCB_DROPDOWN</style> </object> <flag>wxEXPAND|wxALIGN_TOP|wxTOP|wxLEFT|wxRIGHT</flag> <border>4</border> </object> <object class="sizeritem"> <object class="wxStaticText" name="stImplicit"> <label>Implicit</label> <pos>5,82d</pos> </object> <flag>wxALIGN_CENTRE_VERTICAL|wxTOP|wxLEFT|wxRIGHT</flag> <border>4</border> </object> <object class="sizeritem"> <object class="wxCheckBox" name="chkImplicit"> <label></label> <pos>70,80d</pos> <size>13,12d</size> </object> <flag>wxEXPAND|wxALIGN_TOP|wxTOP|wxLEFT|wxRIGHT</flag> <border>4</border> </object> <object class="sizeritem"> <object class="wxStaticText" name="stComment"> <label>Comment</label> <pos>5,97d</pos> </object> <flag>wxALIGN_TOP|wxTOP|wxLEFT|wxRIGHT</flag> <border>4</border> </object> <object class="sizeritem"> <object class="wxTextCtrl" name="txtComment"> <pos>70,95d</pos> <size>135,83d</size> <style>wxTE_MULTILINE</style> </object> <flag>wxEXPAND|wxALL</flag> <border>4</border> </object> <object class="sizeritem"> <object class="wxStaticText" name="stClusterSet"> <label>Use replication</label> <pos>5,183d</pos> </object> <flag>wxALIGN_CENTRE_VERTICAL</flag> </object> <object class="sizeritem"> <object class="wxComboBox" name="cbClusterSet"> <content/> <pos>70,181d</pos> <size>135,12d</size> <style>wxCB_READONLY|wxCB_DROPDOWN</style> </object> <flag>wxEXPAND|wxALIGN_TOP|wxALL</flag> <border>4</border> </object> </object> <selected>1</selected> </object> <pos>2,2d</pos> <size>214,415d</size> </object> </object> <flag>wxALL|wxGROW|wxALIGN_CENTRE</flag> <border>3</border> </object> <growablecols>0</growablecols> <growablerows>0</growablerows> <object class="spacer"> <size>2,2d</size> </object> <object class="sizeritem"> <object class="wxFlexGridSizer"> <cols>7</cols> <object class="spacer"> <size>3,3d</size> </object> <object class="sizeritem"> <object class="wxButton" name="wxID_HELP"> <label>Help</label> <pos>135,220d</pos> </object> </object> <object class="spacer"> <size>3,3d</size> </object> <object class="sizeritem"> <object class="wxButton" name="wxID_OK"> <label>&OK</label> <default>1</default> <pos>135,220d</pos> </object> </object> <object class="spacer"> <size>3,3d</size> </object> <object class="sizeritem"> <object class="wxButton" name="wxID_CANCEL"> <label>&Cancel</label> <pos>176,220d</pos> </object> </object> <object class="spacer"> <size>3,3d</size> </object> <growablecols>2</growablecols> </object> <flag>wxTOP|wxLEFT|wxRIGHT|wxGROW</flag> </object> <object class="spacer"> <size>3,3d</size> </object> <object class="sizeritem"> <object class="unknown" name="unkStatusBar"> <size>-1,15d</size> </object> <flag>wxGROW|wxALIGN_CENTRE</flag> <border>3</border> </object> </object> </object> </resource>
Dave Page a écrit : > On Sat, Jul 19, 2008 at 3:50 PM, Guillaume Lelarge > <guillaume@lelarge.info> wrote: >> Okay... the wxListCtrl resize problem seems to be a wxMac confirmed bug. See >> http://trac.wxwidgets.org/ticket/4814 bug report for more details. Not sure >> about what we should do with this... debug the stuff on wxMac source files? >> or simply put it in the BUGS file and continue the work ? > > I was trying to come up with a test case for this using the xrc sample > app in wxWidgets - however it seems to work fine. I used the changes > below - can you see what's different?: > I worked all the evening on this. The xrc sample app works for me. It even works with our Definition notebook page. So, we should be able to make it work on pgAdmin. I tried to simplify our xrc file in pgAdmin, but I couldn't find a way to make it work. -- Guillaume. http://www.postgresqlfr.org http://dalibo.com
Dave Page a écrit : > On Mon, Jul 21, 2008 at 6:04 PM, Guillaume Lelarge > <guillaume@lelarge.info> wrote: >> Reducing the border works here too. To have the blue border on each side of >> the control, we need to make the control bigger. For example, cbSourceType >> and cbTargetType have 12 for width. With 14, they show the bottom highlight. > > Ahh, yes, that got it :-) > >>> Thoughts? Aside from that, I think that one is ready to go - and >>> should set the standard for the following dialogues :-) >>> >> There's still one thing that bothers me. The "Use replication" label seems >> closer to the left side of the window's border. > > Yes, I think it might be a little low as well. > I'll see what I can do to make it prettier. >> And I need to check the border and width changes on Linux and Windows. > > One side effect - it's causing 'disappearing comboxbox' syndrome on > Mac now - see the attached screenshot. Resize slightly, and all is > fine. > OK, will do. > Getting these right is really tiresome isn't it? I think it will be > well worth it though - your effort is definitely appreciated. > Yes, it is tiresome. Changing something can bork the entire dialog. Making it pretty on one platform can bork it on the two others. Not sure I like the crossplatform capacity anymore :) Anyways, I just hope I don't annoy anyone with so many mails and attachments. I'm thinking of putting a tarball somewhere with all the last changes instead of sending multiple patches on this list. -- Guillaume. http://www.postgresqlfr.org http://dalibo.com
On Tue, Jul 22, 2008 at 2:52 PM, Guillaume Lelarge <guillaume@lelarge.info> wrote: > Yes, it is tiresome. Changing something can bork the entire dialog. Making > it pretty on one platform can bork it on the two others. Not sure I like the > crossplatform capacity anymore :) I feel your pain. > Anyways, I just hope I don't annoy anyone with so many mails and > attachments. I'm thinking of putting a tarball somewhere with all the last > changes instead of sending multiple patches on this list. This list is fine - it's what -hackers is intended for. -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com
On Wed, Jul 23, 2008 at 12:30 AM, Guillaume Lelarge <guillaume@lelarge.info> wrote: > Here is a patch that merges all the others. I don't see another way to do it > without completely loosing track of the version of each individual patch. > > This patch fixes the display issues on Mac OS X. It adds a few other dialogs > (dlgColumn, dlgConversion, dlgDatabase, dlgDomain). dlgCast/dlgConversion/dlgColumn/dlgDomain: - If you look closely, there is some inconsistency with the label top positions relative to the control tops. For example, on OSX, the top of the 'n' on the end lines up with the top of the combobox on dlgCast. Other labels are similarly high, though it seems to vary. Aside from that, they're ready to go. dlgDatabase: - The wxListCtrl problem is present on the variables tab. - The boolean variable checkbox doesn't display at all on my Mac. - The text variable checkbox is too small on the variables tab (missing border) - Vertical alignment of labels is a little out. - Privileges tab doesn't resize yet (but I guess you know that!) > Remaining issue: > * wxListCtrl can grow but doesn't want to shrink If we can get a reproducible small test case, we might be able to get this looked at. > New issue: > * doing anything with chkValue (hiding, showing, changing the value) on > dlgDatabase cause a crash Couldn't reproduce - assuming this is the checkbox on the variables tab when a boolean guc is selected, I couldn't even get it to display on the Mac. Have you tried a 'make clean; make all' after rebuilding xrcdialogs.cpp? That can sometimes help. One additional issue that's been there for years - the left-hand alignment of textboxes and editable-listboxes isn't quite right on Mac (it may be out on other platforms - it's just more noticable on the mac). For example, look at the alignment of the datatype and name controls on dlgColumn. Not sure what, if anything, we can do about that - it may be a wxWidgets issue. -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com
Dave Page a écrit : > On Wed, Jul 23, 2008 at 12:30 AM, Guillaume Lelarge > <guillaume@lelarge.info> wrote: >> Here is a patch that merges all the others. I don't see another way to do it >> without completely loosing track of the version of each individual patch. >> >> This patch fixes the display issues on Mac OS X. It adds a few other dialogs >> (dlgColumn, dlgConversion, dlgDatabase, dlgDomain). > > dlgCast/dlgConversion/dlgColumn/dlgDomain: > > - If you look closely, there is some inconsistency with the label top > positions relative to the control tops. For example, on OSX, the top > of the 'n' on the end lines up with the top of the combobox on > dlgCast. Other labels are similarly high, though it seems to vary. > I don't know a way to get rid of this without going back to wxALIGN_CENTER_VERTICAL. My patch now has this align parameter. > Aside from that, they're ready to go. > > dlgDatabase: > > - The wxListCtrl problem is present on the variables tab. Yes, that's the biggest issue I have. > - The boolean variable checkbox doesn't display at all on my Mac. Hum, sorry. My patch disables it. > - The text variable checkbox is too small on the variables tab (missing border) > - Vertical alignment of labels is a little out. Fixed. > - Privileges tab doesn't resize yet (but I guess you know that!) Remains to be done. >> Remaining issue: >> * wxListCtrl can grow but doesn't want to shrink > > If we can get a reproducible small test case, we might be able to get > this looked at. > I need to work on this. With the text search work, I know how to add a small dialog :) >> New issue: >> * doing anything with chkValue (hiding, showing, changing the value) on >> dlgDatabase cause a crash > > Couldn't reproduce - assuming this is the checkbox on the variables > tab when a boolean guc is selected, I couldn't even get it to display > on the Mac. Have you tried a 'make clean; make all' after rebuilding > xrcdialogs.cpp? That can sometimes help. > Nope, it didn't. > One additional issue that's been there for years - the left-hand > alignment of textboxes and editable-listboxes isn't quite right on Mac > (it may be out on other platforms - it's just more noticable on the > mac). For example, look at the alignment of the datatype and name > controls on dlgColumn. Not sure what, if anything, we can do about > that - it may be a wxWidgets issue. > -- Guillaume. http://www.postgresqlfr.org http://dalibo.com