Thread: ctlCombobox SetEditable to false on Linux

Could I get rid of it?

I probably need to explain a bit more (can't do less obviously :) ).

I don't get what workaround it tries to achieve, but I definitely do get
what advantages we would have on linux if we get rid of that three lines
of code.

What I would like to do is get rid of this:

#ifdef __WXGTK__
    SetEditable(false);
#endif

starting at line 176, on file ctlComboBox.cpp, and commit the patch. I
would then be able to see if I find any issues, even when I'm working on
other patches. If I can't do this, I actually don't know how I can find
that. Of course, I could modify that on my git repositories, but it's
dangerous: it could get commited without me noticing it.

So, any objection?


--
Guillaume
 http://www.postgresql.fr
 http://dalibo.com

Hi Guillaume,

Auto-completion functionality does not behave as expected on linux with GTK.
Hence, we disabled editing combo-box on GTK only.

Try & check if you can do something about it.
I gave a little try on it, but it did not go well for me because of lack of expertise and time constraint. :-(

Le 28/09/2010 06:59, Ashesh Vashi a écrit :
> Hi Guillaume,
>
> Auto-completion functionality does not behave as expected on linux with GTK.
> Hence, we disabled editing combo-box on GTK only.
>

Yeah, Dave told me that. But I don't quite get what it means. When I
worked a bit, I see there's no auto-completion but at least a user can
type something. So, I don't really see the issue. Not ahving
autocompletion is bad, but not as bad as having to choose the type on
the list with a mouse. I would much prefer to be allowed to enter the
type without auto-completion. And I think I'm not the only one.


--
Guillaume
 http://www.postgresql.fr
 http://dalibo.com