Thread: pgAdmin bug - SQL creation for foreign keys

On Thu, Jul 11, 2013 at 4:55 PM, Dave Page <dpage@pgadmin.org> wrote:

Dinesh, can you investigate this please?

Sure Dave.

 

On Thu, Jul 11, 2013 at 11:42 AM, Jakub Trmota <jakub@trmota.cz> wrote:
> Hello,
> I found bug in pgAdmin III 1.16.1 on Windows 7 (x64). When I use czech
> interface and want to add foreign key, this buggy SQL is generated:
>
> ALTER TABLE app_cache_journal
>   ADD FOREIGN KEY (entry) REFERENCES acl_object_parents (object_id) ON
> UPDATE ochránit (RESTRICT) ON DELETE kaskádová akce (CASCADE);
>
> Correct SQL is:
>
> ALTER TABLE app_cache_journal
>   ADD FOREIGN KEY (entry) REFERENCES acl_object_parents (object_id) ON
> UPDATE RESTRICT ON DELETE CASCADE;
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers

Thanks.

Dinesh

-- 
Dinesh Kumar

Software Engineer

Ph: +918087463317

Skype ID: dinesh.kumar432

www.enterprisedb.com

Follow us on Twitter
@EnterpriseDB 

Visit EnterpriseDB for tutorials, webinars, whitepapers and more

 

Hi Dave,

On Mon, Jul 15, 2013 at 6:55 PM, Dinesh Kumar <dinesh.kumar@enterprisedb.com> wrote:

Hi Dave,

I am able to re-produce the reported issue and with the create new role dialogue box. Please find the attached patch for these reported cases.

This fix seems reasonable if we want the keywords to be translated in the UI, but I don't think we do, because they are keywords not natural language. Can we just prevent them being translated in the first place? If they're in the XRC file, that may require us to reset the labels to un-translated strings in code.

Thanks Dave. Let me send you new patch with this suggested approach.

Dinesh

-- 
Dinesh Kumar

Software Engineer

Ph: +918087463317

Skype ID: dinesh.kumar432

www.enterprisedb.com

Follow us on Twitter
@EnterpriseDB 

Visit EnterpriseDB for tutorials, webinars, whitepapers and more

Hi Dave,

Further to my understanding, we don't any option available to deal untranslated strings in XRC files. Hence, i have reset the label text with the keywords. And also i have found this case with some other dialogue boxes, and adding fix for those also.

Please find the attached patch for the same, and let me know your inputs.

Thanks in advance.

Dinesh

-- 
Dinesh Kumar

Software Engineer

Ph: +918087463317

Skype ID: dinesh.kumar432

www.enterprisedb.com

Follow us on Twitter
@EnterpriseDB 

Visit EnterpriseDB for tutorials, webinars, whitepapers and more

On Tue, Jul 16, 2013 at 1:05 PM, Dinesh Kumar <dinesh.kumar@enterprisedb.com> wrote:

Hi Dave,

On Mon, Jul 15, 2013 at 6:55 PM, Dinesh Kumar <dinesh.kumar@enterprisedb.com> wrote:

Hi Dave,

I am able to re-produce the reported issue and with the create new role dialogue box. Please find the attached patch for these reported cases.

This fix seems reasonable if we want the keywords to be translated in the UI, but I don't think we do, because they are keywords not natural language. Can we just prevent them being translated in the first place? If they're in the XRC file, that may require us to reset the labels to un-translated strings in code.

Thanks Dave. Let me send you new patch with this suggested approach.

Dinesh

-- 
Dinesh Kumar

Software Engineer

Ph: +918087463317

Skype ID: dinesh.kumar432

www.enterprisedb.com

Follow us on Twitter
@EnterpriseDB 

Visit EnterpriseDB for tutorials, webinars, whitepapers and more

Thanks - patch applied with a couple of minor changes:

- I reworded the comments.

- I removed the changes to dlgIndex.xrc and one of the corrsponding changes in dlgIndex.cpp. They changed the labelling that was previously correct.

On Wed, Jul 17, 2013 at 6:09 PM, Dinesh Kumar <dinesh.kumar@enterprisedb.com> wrote:

Hi Dave,

Further to my understanding, we don't any option available to deal untranslated strings in XRC files. Hence, i have reset the label text with the keywords. And also i have found this case with some other dialogue boxes, and adding fix for those also.

Please find the attached patch for the same, and let me know your inputs.

Thanks in advance.

Dinesh

-- 
Dinesh Kumar

Software Engineer

Ph: +918087463317

Skype ID: dinesh.kumar432

www.enterprisedb.com

Follow us on Twitter
@EnterpriseDB 

Visit EnterpriseDB for tutorials, webinars, whitepapers and more

On Tue, Jul 16, 2013 at 1:05 PM, Dinesh Kumar <dinesh.kumar@enterprisedb.com> wrote:

Hi Dave,

On Mon, Jul 15, 2013 at 6:55 PM, Dinesh Kumar <dinesh.kumar@enterprisedb.com> wrote:

Hi Dave,

I am able to re-produce the reported issue and with the create new role dialogue box. Please find the attached patch for these reported cases.

This fix seems reasonable if we want the keywords to be translated in the UI, but I don't think we do, because they are keywords not natural language. Can we just prevent them being translated in the first place? If they're in the XRC file, that may require us to reset the labels to un-translated strings in code.

Thanks Dave. Let me send you new patch with this suggested approach.

Dinesh

-- 
Dinesh Kumar

Software Engineer

Ph: +918087463317

Skype ID: dinesh.kumar432

www.enterprisedb.com

Follow us on Twitter
@EnterpriseDB 

Visit EnterpriseDB for tutorials, webinars, whitepapers and more

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company