Thread: Fixed database statistics report issue
Hi Dave
--

I have fixed one issue where Database statistics table goes beyond the page headers. Below is the steps to reproduce it
1. Connect to database server.
2. Right click on "Databases" root node.
3. Choose Reports->Statistics Report.
4. And give any location for that report.
5. Then it's showing the statistics tables as like the attached screenshot.
Attached is the patch file to fix the issue, also attached the screenshot of the report after fixing the issue. Can you please review it. If fix looks good to you then can you please commit it.
Akshay Joshi
Principal Software Engineer

Phone: +91 20-3058-9517
Mobile: +91 976-788-8246
Mobile: +91 976-788-8246
Attachment
Hi
Otherwise, I think it looks fine. Thanks!
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Fri, Nov 22, 2013 at 11:18 AM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi DaveI have fixed one issue where Database statistics table goes beyond the page headers. Below is the steps to reproduce it1. Connect to database server.2. Right click on "Databases" root node.3. Choose Reports->Statistics Report.4. And give any location for that report.5. Then it's showing the statistics tables as like the attached screenshot.Attached is the patch file to fix the issue, also attached the screenshot of the report after fixing the issue. Can you please review it. If fix looks good to you then can you please commit it.
Can you please fix:
- The indenting, so that the contents of the new div are properly indented (as you've added a level to the document hierarchy).
- The default-xsl.rst file in the docs, so it matches the new default.
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
On Fri, Nov 22, 2013 at 8:51 PM, Dave Page <dpage@pgadmin.org> wrote:
HiOn Fri, Nov 22, 2013 at 11:18 AM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:Hi DaveI have fixed one issue where Database statistics table goes beyond the page headers. Below is the steps to reproduce it1. Connect to database server.2. Right click on "Databases" root node.3. Choose Reports->Statistics Report.4. And give any location for that report.5. Then it's showing the statistics tables as like the attached screenshot.Attached is the patch file to fix the issue, also attached the screenshot of the report after fixing the issue. Can you please review it. If fix looks good to you then can you please commit it.Can you please fix:- The indenting, so that the contents of the new div are properly indented (as you've added a level to the document hierarchy).- The default-xsl.rst file in the docs, so it matches the new default.Otherwise, I think it looks fine. Thanks!
Done. Attached is the modified patch.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Akshay Joshi
Principal Software Engineer

Phone: +91 20-3058-9517
Mobile: +91 976-788-8246
Mobile: +91 976-788-8246
Attachment
Thanks - applied.
On Mon, Nov 25, 2013 at 6:24 AM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
On Fri, Nov 22, 2013 at 8:51 PM, Dave Page <dpage@pgadmin.org> wrote:HiOn Fri, Nov 22, 2013 at 11:18 AM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:Hi DaveI have fixed one issue where Database statistics table goes beyond the page headers. Below is the steps to reproduce it1. Connect to database server.2. Right click on "Databases" root node.3. Choose Reports->Statistics Report.4. And give any location for that report.5. Then it's showing the statistics tables as like the attached screenshot.Attached is the patch file to fix the issue, also attached the screenshot of the report after fixing the issue. Can you please review it. If fix looks good to you then can you please commit it.Can you please fix:- The indenting, so that the contents of the new div are properly indented (as you've added a level to the document hierarchy).- The default-xsl.rst file in the docs, so it matches the new default.Otherwise, I think it looks fine. Thanks!Done. Attached is the modified patch.--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company