Thread: Documentation patch

Documentation patch

From

Andreas 'ads' Scherbaum

Date:

03 March 2014, 23:01:01

Hi,

while scrolling through the pgAdmin3 code I found some places where the
Greenplum links are outdated. The attached patch fixes this.

Note: the current code will update the configuration and write a new
link. Not sure if this is the best thing to do, or just replace the link
on the fly.

Also the patch does a better searching for documentation, by looking up
all possible installed Greenplum versions. Not exactly sure when
__WXMSW__ is set - this path is not optimized (pgAdmin3.cpp, around line
1417), I just added a few updated directories.


Regards,

--
                Andreas 'ads' Scherbaum
German PostgreSQL User Group
European PostgreSQL User Group - Board of Directors
Volunteer Regional Contact, Germany - PostgreSQL Project

Attachment

greenplum_doc_2014-03-03.patch

Re: Documentation patch

From

Dave Page

Date:

04 March 2014, 09:45:55

Ashesh, can you have someone look at this and Ads' other patch please?

Thanks.

On Mon, Mar 3, 2014 at 11:00 PM, Andreas 'ads' Scherbaum
<adsmail@wars-nicht.de> wrote:
>
> Hi,
>
> while scrolling through the pgAdmin3 code I found some places where the
> Greenplum links are outdated. The attached patch fixes this.
>
> Note: the current code will update the configuration and write a new link.
> Not sure if this is the best thing to do, or just replace the link on the
> fly.
>
> Also the patch does a better searching for documentation, by looking up all
> possible installed Greenplum versions. Not exactly sure when __WXMSW__ is
> set - this path is not optimized (pgAdmin3.cpp, around line 1417), I just
> added a few updated directories.
>
>
> Regards,
>
> --
>                                 Andreas 'ads' Scherbaum
> German PostgreSQL User Group
> European PostgreSQL User Group - Board of Directors
> Volunteer Regional Contact, Germany - PostgreSQL Project
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: Documentation patch

From

Ashesh Vashi

Date:

04 March 2014, 09:47:01

Akshay,

Can you please take a look at this?

On Tue, Mar 4, 2014 at 3:15 PM, Dave Page <dpage@pgadmin.org> wrote:

Ashesh, can you have someone look at this and Ads' other patch please?

Thanks.

On Mon, Mar 3, 2014 at 11:00 PM, Andreas 'ads' Scherbaum
<adsmail@wars-nicht.de> wrote:
>
> Hi,
>
> while scrolling through the pgAdmin3 code I found some places where the
> Greenplum links are outdated. The attached patch fixes this.
>
> Note: the current code will update the configuration and write a new link.
> Not sure if this is the best thing to do, or just replace the link on the
> fly.
>
> Also the patch does a better searching for documentation, by looking up all
> possible installed Greenplum versions. Not exactly sure when __WXMSW__ is
> set - this path is not optimized (pgAdmin3.cpp, around line 1417), I just
> added a few updated directories.
>
>
> Regards,
>
> --
> Andreas 'ads' Scherbaum
> German PostgreSQL User Group
> European PostgreSQL User Group - Board of Directors
> Volunteer Regional Contact, Germany - PostgreSQL Project
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

http://www.linkedin.com/in/asheshvashi

Re: Documentation patch

From

Akshay Joshi

Date:

04 March 2014, 09:51:15

Sure

On Tue, Mar 4, 2014 at 3:16 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:

Akshay,

Can you please take a look at this?

On Tue, Mar 4, 2014 at 3:15 PM, Dave Page <dpage@pgadmin.org> wrote:
Ashesh, can you have someone look at this and Ads' other patch please?

Thanks.

On Mon, Mar 3, 2014 at 11:00 PM, Andreas 'ads' Scherbaum
<adsmail@wars-nicht.de> wrote:
>
> Hi,
>
> while scrolling through the pgAdmin3 code I found some places where the
> Greenplum links are outdated. The attached patch fixes this.
>
> Note: the current code will update the configuration and write a new link.
> Not sure if this is the best thing to do, or just replace the link on the
> fly.
>
> Also the patch does a better searching for documentation, by looking up all
> possible installed Greenplum versions. Not exactly sure when __WXMSW__ is
> set - this path is not optimized (pgAdmin3.cpp, around line 1417), I just
> added a few updated directories.
>
>
> Regards,
>
> --
> Andreas 'ads' Scherbaum
> German PostgreSQL User Group
> European PostgreSQL User Group - Board of Directors
> Volunteer Regional Contact, Germany - PostgreSQL Project
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
--
Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

http://www.linkedin.com/in/asheshvashi

Akshay Joshi

Principal Software Engineer

Phone: +91 20-3058-9517
Mobile: +91 976-788-8246

Re: Documentation patch

From

Akshay Joshi

Date:

05 March 2014, 09:27:12

I have reviewed the patch. It is working fine on Linux, but on Windows it is not compiling gives "initialization of 'helppath' is skipped by 'case' label" error in misc.cpp (line no 735).

On Tue, Mar 4, 2014 at 3:21 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:

Sure

On Tue, Mar 4, 2014 at 3:16 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Akshay,

Can you please take a look at this?

On Tue, Mar 4, 2014 at 3:15 PM, Dave Page <dpage@pgadmin.org> wrote:
Ashesh, can you have someone look at this and Ads' other patch please?

Thanks.

On Mon, Mar 3, 2014 at 11:00 PM, Andreas 'ads' Scherbaum
<adsmail@wars-nicht.de> wrote:
>
> Hi,
>
> while scrolling through the pgAdmin3 code I found some places where the
> Greenplum links are outdated. The attached patch fixes this.
>
> Note: the current code will update the configuration and write a new link.
> Not sure if this is the best thing to do, or just replace the link on the
> fly.
>
> Also the patch does a better searching for documentation, by looking up all
> possible installed Greenplum versions. Not exactly sure when __WXMSW__ is
> set - this path is not optimized (pgAdmin3.cpp, around line 1417), I just
> added a few updated directories.
>
>
> Regards,
>
> --
> Andreas 'ads' Scherbaum
> German PostgreSQL User Group
> European PostgreSQL User Group - Board of Directors
> Volunteer Regional Contact, Germany - PostgreSQL Project
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
--
Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

http://www.linkedin.com/in/asheshvashi

--
Akshay Joshi
Principal Software Engineer

Phone: +91 20-3058-9517
Mobile: +91 976-788-8246

Akshay Joshi

Principal Software Engineer

Phone: +91 20-3058-9517
Mobile: +91 976-788-8246

Re: Documentation patch

From

Dave Page

Date:

05 March 2014, 09:31:06

On Wed, Mar 5, 2014 at 9:27 AM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:

Hi

I have reviewed the patch. It is working fine on Linux, but on Windows it is not compiling gives "initialization of 'helppath' is skipped by 'case' label" error in misc.cpp (line no 735).

Thanks. I'm not sure if Ads will have a Windows build environment available to him or not. Is it a simple fix?

On Tue, Mar 4, 2014 at 3:21 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Sure

On Tue, Mar 4, 2014 at 3:16 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Akshay,

Can you please take a look at this?

On Tue, Mar 4, 2014 at 3:15 PM, Dave Page <dpage@pgadmin.org> wrote:
Ashesh, can you have someone look at this and Ads' other patch please?

Thanks.

On Mon, Mar 3, 2014 at 11:00 PM, Andreas 'ads' Scherbaum
<adsmail@wars-nicht.de> wrote:
>
> Hi,
>
> while scrolling through the pgAdmin3 code I found some places where the
> Greenplum links are outdated. The attached patch fixes this.
>
> Note: the current code will update the configuration and write a new link.
> Not sure if this is the best thing to do, or just replace the link on the
> fly.
>
> Also the patch does a better searching for documentation, by looking up all
> possible installed Greenplum versions. Not exactly sure when __WXMSW__ is
> set - this path is not optimized (pgAdmin3.cpp, around line 1417), I just
> added a few updated directories.
>
>
> Regards,
>
> --
> Andreas 'ads' Scherbaum
> German PostgreSQL User Group
> European PostgreSQL User Group - Board of Directors
> Volunteer Regional Contact, Germany - PostgreSQL Project
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
--
Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

http://www.linkedin.com/in/asheshvashi

--
Akshay Joshi
Principal Software Engineer

Phone: +91 20-3058-9517
Mobile: +91 976-788-8246

--
Akshay Joshi
Principal Software Engineer

Phone: +91 20-3058-9517
Mobile: +91 976-788-8246

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: Documentation patch

From

Akshay Joshi

Date:

05 March 2014, 09:37:22

On Wed, Mar 5, 2014 at 3:01 PM, Dave Page <dpage@pgadmin.org> wrote:

On Wed, Mar 5, 2014 at 9:27 AM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi

I have reviewed the patch. It is working fine on Linux, but on Windows it is not compiling gives "initialization of 'helppath' is skipped by 'case' label" error in misc.cpp (line no 735).

Hi

Thanks. I'm not sure if Ads will have a Windows build environment available to him or not. Is it a simple fix?

Yes. Variable 'helppath' is declared inside the case label, so if we declare outside the switch statement then it will get fixed.

On Tue, Mar 4, 2014 at 3:21 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Sure

On Tue, Mar 4, 2014 at 3:16 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Akshay,

Can you please take a look at this?

On Tue, Mar 4, 2014 at 3:15 PM, Dave Page <dpage@pgadmin.org> wrote:
Ashesh, can you have someone look at this and Ads' other patch please?

Thanks.

On Mon, Mar 3, 2014 at 11:00 PM, Andreas 'ads' Scherbaum
<adsmail@wars-nicht.de> wrote:
>
> Hi,
>
> while scrolling through the pgAdmin3 code I found some places where the
> Greenplum links are outdated. The attached patch fixes this.
>
> Note: the current code will update the configuration and write a new link.
> Not sure if this is the best thing to do, or just replace the link on the
> fly.
>
> Also the patch does a better searching for documentation, by looking up all
> possible installed Greenplum versions. Not exactly sure when __WXMSW__ is
> set - this path is not optimized (pgAdmin3.cpp, around line 1417), I just
> added a few updated directories.
>
>
> Regards,
>
> --
> Andreas 'ads' Scherbaum
> German PostgreSQL User Group
> European PostgreSQL User Group - Board of Directors
> Volunteer Regional Contact, Germany - PostgreSQL Project
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
--
Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

http://www.linkedin.com/in/asheshvashi

--
Akshay Joshi
Principal Software Engineer

Phone: +91 20-3058-9517
Mobile: +91 976-788-8246

--
Akshay Joshi
Principal Software Engineer

Phone: +91 20-3058-9517
Mobile: +91 976-788-8246

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Akshay Joshi

Principal Software Engineer

Phone: +91 20-3058-9517
Mobile: +91 976-788-8246

Re: Documentation patch

From

Dave Page

Date:

05 March 2014, 09:38:46

On Wed, Mar 5, 2014 at 9:37 AM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:

On Wed, Mar 5, 2014 at 3:01 PM, Dave Page <dpage@pgadmin.org> wrote:

On Wed, Mar 5, 2014 at 9:27 AM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi

I have reviewed the patch. It is working fine on Linux, but on Windows it is not compiling gives "initialization of 'helppath' is skipped by 'case' label" error in misc.cpp (line no 735).

Hi

Thanks. I'm not sure if Ads will have a Windows build environment available to him or not. Is it a simple fix?

Yes. Variable 'helppath' is declared inside the case label, so if we declare outside the switch statement then it will get fixed.

Please go ahead and fix it. A one liner is quicker to do than passing it back and forth.

Thanks.

On Tue, Mar 4, 2014 at 3:21 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Sure

On Tue, Mar 4, 2014 at 3:16 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Akshay,

Can you please take a look at this?

On Tue, Mar 4, 2014 at 3:15 PM, Dave Page <dpage@pgadmin.org> wrote:
Ashesh, can you have someone look at this and Ads' other patch please?

Thanks.

On Mon, Mar 3, 2014 at 11:00 PM, Andreas 'ads' Scherbaum
<adsmail@wars-nicht.de> wrote:
>
> Hi,
>
> while scrolling through the pgAdmin3 code I found some places where the
> Greenplum links are outdated. The attached patch fixes this.
>
> Note: the current code will update the configuration and write a new link.
> Not sure if this is the best thing to do, or just replace the link on the
> fly.
>
> Also the patch does a better searching for documentation, by looking up all
> possible installed Greenplum versions. Not exactly sure when __WXMSW__ is
> set - this path is not optimized (pgAdmin3.cpp, around line 1417), I just
> added a few updated directories.
>
>
> Regards,
>
> --
> Andreas 'ads' Scherbaum
> German PostgreSQL User Group
> European PostgreSQL User Group - Board of Directors
> Volunteer Regional Contact, Germany - PostgreSQL Project
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
--
Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

http://www.linkedin.com/in/asheshvashi

--
Akshay Joshi
Principal Software Engineer

Phone: +91 20-3058-9517
Mobile: +91 976-788-8246

--
Akshay Joshi
Principal Software Engineer

Phone: +91 20-3058-9517
Mobile: +91 976-788-8246

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

--
Akshay Joshi
Principal Software Engineer

Phone: +91 20-3058-9517
Mobile: +91 976-788-8246

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: Documentation patch

From

Andreas 'ads' Scherbaum

Date:

05 March 2014, 09:49:18

On 03/05/2014 10:38 AM, Dave Page wrote:
>
> Please go ahead and fix it. A one liner is quicker to do than passing it
> back and forth.

Right, I have no Windows build environment available.

Thanks for fixing this.


Regards,

--
                Andreas 'ads' Scherbaum
German PostgreSQL User Group
European PostgreSQL User Group - Board of Directors
Volunteer Regional Contact, Germany - PostgreSQL Project

Re: Documentation patch

From

Akshay Joshi

Date:

05 March 2014, 10:47:40

Attached is the modified patch which will fix the compilation issue on Windows.

On Wed, Mar 5, 2014 at 3:19 PM, Andreas 'ads' Scherbaum <adsmail@wars-nicht.de> wrote:

On 03/05/2014 10:38 AM, Dave Page wrote:

Please go ahead and fix it. A one liner is quicker to do than passing it
back and forth.

Right, I have no Windows build environment available.

Thanks for fixing this.

Regards,

--
Andreas 'ads' Scherbaum
German PostgreSQL User Group
European PostgreSQL User Group - Board of Directors
Volunteer Regional Contact, Germany - PostgreSQL Project

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Akshay Joshi

Principal Software Engineer

Phone: +91 20-3058-9517
Mobile: +91 976-788-8246

Attachment

greenplum_doc_2014-03-03_v1.patch

Re: Documentation patch

From

Andreas 'ads' Scherbaum

Date:

13 March 2014, 19:23:25

Hello,

On 03/05/2014 11:47 AM, Akshay Joshi wrote:
>
> Attached is the modified patch which will fix the compilation issue on
> Windows.

Will someone commit this, or is it just me not seeing the commit in git?


Thanks,

--
                Andreas 'ads' Scherbaum
German PostgreSQL User Group
European PostgreSQL User Group - Board of Directors
Volunteer Regional Contact, Germany - PostgreSQL Project

Re: Documentation patch

From

Ashesh Vashi

Date:

02 April 2014, 10:14:00

Done with some minor changes.

On Fri, Mar 14, 2014 at 12:53 AM, Andreas 'ads' Scherbaum <adsmail@wars-nicht.de> wrote:

Hello,

On 03/05/2014 11:47 AM, Akshay Joshi wrote:

Attached is the modified patch which will fix the compilation issue on
Windows.

Will someone commit this, or is it just me not seeing the commit in git?

Thanks,

--
Andreas 'ads' Scherbaum
German PostgreSQL User Group
European PostgreSQL User Group - Board of Directors
Volunteer Regional Contact, Germany - PostgreSQL Project

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

--
--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

http://www.linkedin.com/in/asheshvashi