Thread: pgAdmin III commit: Resolved an issue related enable/disable menu items
On Wed, Sep 23, 2015 at 10:23 AM, J.F. Oster <jinfroster@mail.ru> wrote:
Hi Ashesh,
Favourite's issue is resolved, but looks like Edit - Cut/Copy/Paste
items are disabled all the time (seen on Ubuntu, Kubuntu).
I've tested the patch couple of times on Ubuntu, and OSX both before committing the changes.
Do you have time to look into it?
Tuesday, September 22, 2015, 10:56:32 AM, you wrote:
AV> Resolved an issue related enable/disable menu items in Query Editor
AV> specifically for Unity Desktop Environment.
AV> wxWidgets was not able to identify the current focused control in some
AV> cases, during certain event generation. And, that was resulting into
AV> disabling the wrong menu items.
AV> i.e.
AV> Copy, Paste, Undo, Redo, Cut, Paste, Add/Manage favourite menu(s)
AV> In order to resolve the issue, we will not consider the events
AV> generated, but - no control gets focused, while enabling/disabling the
AV> menus.
AV> Branch
AV> ------
AV> master
AV> Details
AV> -------
AV> http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=cd9f615564334ed91d4760c971beae249cf9bd83
AV> Modified Files
AV> --------------
AV> CHANGELOG | 3 +++
AV> pgadmin/frm/frmQuery.cpp | 59
AV> +++++++++++++++++++++++++++-------------------
AV> 2 files changed, 38 insertions(+), 24 deletions(-)
--
Best regards,
J.F.
On Wed, Sep 23, 2015 at 10:27 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
On Wed, Sep 23, 2015 at 10:23 AM, J.F. Oster <jinfroster@mail.ru> wrote:Hi Ashesh,
Favourite's issue is resolved, but looks like Edit - Cut/Copy/Paste
items are disabled all the time (seen on Ubuntu, Kubuntu).I've tested the patch couple of times on Ubuntu, and OSX both before committing the changes.Do you have time to look into it?
Got the reason.
Thanks for the report.
Tuesday, September 22, 2015, 10:56:32 AM, you wrote:
AV> Resolved an issue related enable/disable menu items in Query Editor
AV> specifically for Unity Desktop Environment.
AV> wxWidgets was not able to identify the current focused control in some
AV> cases, during certain event generation. And, that was resulting into
AV> disabling the wrong menu items.
AV> i.e.
AV> Copy, Paste, Undo, Redo, Cut, Paste, Add/Manage favourite menu(s)
AV> In order to resolve the issue, we will not consider the events
AV> generated, but - no control gets focused, while enabling/disabling the
AV> menus.
AV> Branch
AV> ------
AV> master
AV> Details
AV> -------
AV> http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=cd9f615564334ed91d4760c971beae249cf9bd83
AV> Modified Files
AV> --------------
AV> CHANGELOG | 3 +++
AV> pgadmin/frm/frmQuery.cpp | 59
AV> +++++++++++++++++++++++++++-------------------
AV> 2 files changed, 38 insertions(+), 24 deletions(-)
--
Best regards,
J.F.
On Wed, Sep 23, 2015 at 10:36 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
On Wed, Sep 23, 2015 at 10:27 AM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:On Wed, Sep 23, 2015 at 10:23 AM, J.F. Oster <jinfroster@mail.ru> wrote:Hi Ashesh,
Favourite's issue is resolved, but looks like Edit - Cut/Copy/Paste
items are disabled all the time (seen on Ubuntu, Kubuntu).I've tested the patch couple of times on Ubuntu, and OSX both before committing the changes.Do you have time to look into it?Got the reason.Thanks for the report.
Thanks once again.
Please check now.
Tuesday, September 22, 2015, 10:56:32 AM, you wrote:
AV> Resolved an issue related enable/disable menu items in Query Editor
AV> specifically for Unity Desktop Environment.
AV> wxWidgets was not able to identify the current focused control in some
AV> cases, during certain event generation. And, that was resulting into
AV> disabling the wrong menu items.
AV> i.e.
AV> Copy, Paste, Undo, Redo, Cut, Paste, Add/Manage favourite menu(s)
AV> In order to resolve the issue, we will not consider the events
AV> generated, but - no control gets focused, while enabling/disabling the
AV> menus.
AV> Branch
AV> ------
AV> master
AV> Details
AV> -------
AV> http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=cd9f615564334ed91d4760c971beae249cf9bd83
AV> Modified Files
AV> --------------
AV> CHANGELOG | 3 +++
AV> pgadmin/frm/frmQuery.cpp | 59
AV> +++++++++++++++++++++++++++-------------------
AV> 2 files changed, 38 insertions(+), 24 deletions(-)
--
Best regards,
J.F.