Thread: Re: [pgadmin-support] Error about inherited table of column in pgadmin1.20.0

Hi Ashesh

On Thu, Oct 15, 2015 at 1:51 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:

On Thu, Oct 15, 2015 at 11:15 AM, JasmineLiu <liuyuanyuangogo@gmail.com> wrote:

Hi, all !

This is Liu Yuanyuan.
I find the inherited table of column shown in pgadmin 1.20.0, sometimes
isn’t right. That should be a bug.
Hope someone to do something about this problem!
Here is my example:

First I execute the following sql in pgadmin 1.20.0 by query tool:
create schema test;
create table test.a1(id int);
create table test.a2(id int, name varchar);
create table test.a3(age int);
create table test.aa() inherits(test.a1,test.a2,test.a3);


Then in main view of pgadmin 1.20.0：
It shows the column age is inherited from table test.a2, this is not right.
<http://postgresql.nabble.com/file/n5870044/1.jpg>
<http://postgresql.nabble.com/file/n5870044/2.jpg>

Looks like a bug to me.

Akshay,

Can you please take a look at it?

   I have fixed the issue, attached is the patch file. Can you please review it and if it looks good can you please commit the code. 

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

http://www.linkedin.com/in/asheshvashi

 

I also check the code of pgadmin 1.20.0, I think the method to specify the
inherited table of columns is not correct,especially when the inherited
tables have same column.

Thanks and hope to hear from you soon!

Best wishes!
Liu Yuanyuan




--
View this message in context: http://postgresql.nabble.com/Error-about-inherited-table-of-column-in-pgadmin1-20-0-tp5870044.html
Sent from the PostgreSQL - pgadmin support mailing list archive at Nabble.com.


--
Sent via pgadmin-support mailing list (pgadmin-support@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-support

--

Akshay Joshi

Principal Software Engineer 

Phone: +91 20-3058-9517
Mobile: +91 976-788-8246

On Fri, Oct 16, 2015 at 5:40 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:

Hi Ashesh

Hi Akshay,

I've modified the patch a little bit for betterment.

Can you please review and test it?

--

Thanks & Regards,

Ashesh Vashi

On Thu, Oct 15, 2015 at 1:51 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:

On Thu, Oct 15, 2015 at 11:15 AM, JasmineLiu <liuyuanyuangogo@gmail.com> wrote:

Hi, all !

This is Liu Yuanyuan.
I find the inherited table of column shown in pgadmin 1.20.0, sometimes
isn’t right. That should be a bug.
Hope someone to do something about this problem!
Here is my example:

First I execute the following sql in pgadmin 1.20.0 by query tool:
create schema test;
create table test.a1(id int);
create table test.a2(id int, name varchar);
create table test.a3(age int);
create table test.aa() inherits(test.a1,test.a2,test.a3);


Then in main view of pgadmin 1.20.0：
It shows the column age is inherited from table test.a2, this is not right.
<http://postgresql.nabble.com/file/n5870044/1.jpg>
<http://postgresql.nabble.com/file/n5870044/2.jpg>

Looks like a bug to me.

Akshay,

Can you please take a look at it?

   I have fixed the issue, attached is the patch file. Can you please review it and if it looks good can you please commit the code. 

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

http://www.linkedin.com/in/asheshvashi

 

I also check the code of pgadmin 1.20.0, I think the method to specify the
inherited table of columns is not correct,especially when the inherited
tables have same column.

Thanks and hope to hear from you soon!

Best wishes!
Liu Yuanyuan




--
View this message in context: http://postgresql.nabble.com/Error-about-inherited-table-of-column-in-pgadmin1-20-0-tp5870044.html
Sent from the PostgreSQL - pgadmin support mailing list archive at Nabble.com.


--
Sent via pgadmin-support mailing list (pgadmin-support@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-support

--

Akshay Joshi

Principal Software Engineer 

Phone: +91 20-3058-9517
Mobile: +91 976-788-8246

Hi Ashesh

On Fri, Oct 23, 2015 at 1:27 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:

On Fri, Oct 16, 2015 at 5:40 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:

Hi Ashesh

Hi Akshay,

I've modified the patch a little bit for betterment.

Can you please review and test it?

   Patch looks good to me. I have tested it, works fine.

--

Thanks & Regards,

Ashesh Vashi

On Thu, Oct 15, 2015 at 1:51 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:

On Thu, Oct 15, 2015 at 11:15 AM, JasmineLiu <liuyuanyuangogo@gmail.com> wrote:

Hi, all !

This is Liu Yuanyuan.
I find the inherited table of column shown in pgadmin 1.20.0, sometimes
isn’t right. That should be a bug.
Hope someone to do something about this problem!
Here is my example:

First I execute the following sql in pgadmin 1.20.0 by query tool:
create schema test;
create table test.a1(id int);
create table test.a2(id int, name varchar);
create table test.a3(age int);
create table test.aa() inherits(test.a1,test.a2,test.a3);


Then in main view of pgadmin 1.20.0：
It shows the column age is inherited from table test.a2, this is not right.
<http://postgresql.nabble.com/file/n5870044/1.jpg>
<http://postgresql.nabble.com/file/n5870044/2.jpg>

Looks like a bug to me.

Akshay,

Can you please take a look at it?

   I have fixed the issue, attached is the patch file. Can you please review it and if it looks good can you please commit the code. 

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

http://www.linkedin.com/in/asheshvashi

 

I also check the code of pgadmin 1.20.0, I think the method to specify the
inherited table of columns is not correct,especially when the inherited
tables have same column.

Thanks and hope to hear from you soon!

Best wishes!
Liu Yuanyuan




--
View this message in context: http://postgresql.nabble.com/Error-about-inherited-table-of-column-in-pgadmin1-20-0-tp5870044.html
Sent from the PostgreSQL - pgadmin support mailing list archive at Nabble.com.


--
Sent via pgadmin-support mailing list (pgadmin-support@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-support

--

Akshay Joshi

Principal Software Engineer 

Phone: +91 20-3058-9517
Mobile: +91 976-788-8246

--

Akshay Joshi

Principal Software Engineer 

Phone: +91 20-3058-9517
Mobile: +91 976-788-8246