Thread: [pgAdmin4][patch]: String evaluation issue

[pgAdmin4][patch]: String evaluation issue

From
Neel Patel
Date:
Hi,

Please find attached patch file containing the fix for the below issue.
This issue is reported by Dave during the debugger code review and we have removed the same issue from other files where we used.

Issue :- 

When we use below string to form the error message then it will not work because Jinja will evaluate the string " + err.errormsg + " before it gets evaluated as JS by the browser.

           alertify.error("{{ _('" + err.errormsg + "') }}");


Do review it and let us know for any comments.

Thanks,
Neel Patel

Attachment

Re: [pgAdmin4][patch]: String evaluation issue

From
Dave Page
Date:
Thanks, applied.

On Monday, April 18, 2016, Neel Patel <neel.patel@enterprisedb.com> wrote:
Hi,

Please find attached patch file containing the fix for the below issue.
This issue is reported by Dave during the debugger code review and we have removed the same issue from other files where we used.

Issue :- 

When we use below string to form the error message then it will not work because Jinja will evaluate the string " + err.errormsg + " before it gets evaluated as JS by the browser.

           alertify.error("{{ _('" + err.errormsg + "') }}");


Do review it and let us know for any comments.

Thanks,
Neel Patel



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company