Thread: variable scope issue in server js [pgadmin4]

Hi,

PFA patch for server.js. Replaced ";" (semicolon) with ","  (coma) in variable declaration.

Issue: This was changing scope of all the variables declared after ";" (semicolon) from local to global and therefore affecting all other local variables with same name at different place in same file.

-- 

Harshal Dhumal

Software Engineer 

EenterpriseDB

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Hi Akshay,

Murtuza hasn't fixed it in all places. He missed in following tow functions

connect_server and disconnect_server

-- 

Harshal Dhumal

Software Engineer 

EenterpriseDB

On Thu, May 12, 2016 at 7:38 PM, Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:

Hi 

On Thu, May 12, 2016 at 5:05 PM, Harshal Dhumal <harshal.dhumal@enterprisedb.com> wrote:

Hi,

PFA patch for server.js. Replaced ";" (semicolon) with ","  (coma) in variable declaration.

Issue: This was changing scope of all the variables declared after ";" (semicolon) from local to global and therefore affecting all other local variables with same name at different place in same file.

   Thanks- it is already being committed with the patch for "Named Restore Point" send by Murtuza. 

-- 

Harshal Dhumal

Software Engineer 

EenterpriseDB

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

--

Akshay Joshi

Principal Software Engineer 

Phone: +91 20-3058-9517
Mobile: +91 976-788-8246