Home > mailing lists

Thread: [pgAdmin4][Patch]: RM#1293 - SQL pane is not displaying GRANT queries in Function, Procedure and Trigger node

[pgAdmin4][Patch]: RM#1293 - SQL pane is not displaying GRANT queries in Function, Procedure and Trigger node

From

Surinder Kumar

Date:

02 June 2016, 13:56:14

Hi,

Please find attached patch for RM#1293.

Add support to display GRANT privilege query in SQL Pane.

Please review.

Thanks,

Surinder Kumar

Attachment

display_GRANT_queries_in_SQL_PANE.patch

Re: [pgAdmin4][Patch]: RM#1293 - SQL pane is not displaying GRANT queries in Function, Procedure and Trigger node

From

Surinder Kumar

Date:

02 June 2016, 14:03:09

Please ignore this patch. I will send another patch.

On Thu, Jun 2, 2016 at 7:25 PM, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote:

Hi,

Please find attached patch for RM#1293.
Add support to display GRANT privilege query in SQL Pane.

Please review.

Thanks,
Surinder Kumar

Re: [pgAdmin4][Patch]: RM#1293 - SQL pane is not displaying GRANT queries in Function, Procedure and Trigger node

From

Surinder Kumar

Date:

03 June 2016, 10:01:39

Hi,

Please find attached patch for:

1. RM#1293 - SQL pane is not displaying GRANT queries in functions node

2. RM#1294 - Comments are not visible in sql pane for trigger functions and functions

Explanation:

Previously we we using 'get_defintion.sql' template to generate SQL for SQL pane for functions, procedure & trigger functions node.

but GRANT statements and COMMENTS changes were missing. In order to fix that, now we have used both 'create.sql' and 'get_definition.sql' templates to generate full SQL query

for SQL pane.

Please review.

On Thu, Jun 2, 2016 at 7:32 PM, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote:

Please ignore this patch. I will send another patch.

On Thu, Jun 2, 2016 at 7:25 PM, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote:
Hi,

Please find attached patch for RM#1293.
Add support to display GRANT privilege query in SQL Pane.

Please review.

Thanks,
Surinder Kumar

Attachment

fix_for_RM#1293_and_RM#1294.patch

Re: [pgAdmin4][Patch]: RM#1293 - SQL pane is not displaying GRANT queries in Function, Procedure and Trigger node

From

Surinder Kumar

Date:

06 June 2016, 13:48:06

Hi,

Please find updated patch:

Issue: Code changes are not consistent with the present code in functions/__init__.py, like don't rename variable func_def to func_defintion until it is required.

Review comment given by Ashesh personally.

Please review.

On Fri, Jun 3, 2016 at 3:31 PM, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote:

Hi,

Please find attached patch for:
1. RM#1293 - SQL pane is not displaying GRANT queries in functions node
2. RM#1294 - Comments are not visible in sql pane for trigger functions and functions

Explanation:
Previously we we using 'get_defintion.sql' template to generate SQL for SQL pane for functions, procedure & trigger functions node.
but GRANT statements and COMMENTS changes were missing. In order to fix that, now we have used both 'create.sql' and 'get_definition.sql' templates to generate full SQL query
for SQL pane.

Please review.

On Thu, Jun 2, 2016 at 7:32 PM, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote:
Please ignore this patch. I will send another patch.

On Thu, Jun 2, 2016 at 7:25 PM, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote:
Hi,

Please find attached patch for RM#1293.
Add support to display GRANT privilege query in SQL Pane.

Please review.

Thanks,
Surinder Kumar

Attachment

fix_for_RM#1293_and_RM#1294_v1.patch

Re: Re: [pgAdmin4][Patch]: RM#1293 - SQL pane is not displaying GRANT queries in Function, Procedure and Trigger node

From

Harshal Dhumal

Date:

22 July 2016, 07:56:14

Hi,

PFA rebased patch for RM1293 and RM1294.

Harshal Dhumal

Software Engineer

EnterpriseDB India: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Mon, Jun 6, 2016 at 7:17 PM, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote:

Hi,

Please find updated patch:
Issue: Code changes are not consistent with the present code in functions/__init__.py, like don't rename variable func_def to func_defintion until it is required.
Review comment given by Ashesh personally.

Please review.

On Fri, Jun 3, 2016 at 3:31 PM, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote:
Hi,

Please find attached patch for:
1. RM#1293 - SQL pane is not displaying GRANT queries in functions node
2. RM#1294 - Comments are not visible in sql pane for trigger functions and functions

Explanation:
Previously we we using 'get_defintion.sql' template to generate SQL for SQL pane for functions, procedure & trigger functions node.
but GRANT statements and COMMENTS changes were missing. In order to fix that, now we have used both 'create.sql' and 'get_definition.sql' templates to generate full SQL query
for SQL pane.

Please review.

On Thu, Jun 2, 2016 at 7:32 PM, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote:
Please ignore this patch. I will send another patch.

On Thu, Jun 2, 2016 at 7:25 PM, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote:
Hi,

Please find attached patch for RM#1293.
Add support to display GRANT privilege query in SQL Pane.

Please review.

Thanks,
Surinder Kumar

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Attachment

fix_for_RM#1293_and_RM#1294_v2.patch

Re: Re: [pgAdmin4][Patch]: RM#1293 - SQL pane is not displaying GRANT queries in Function, Procedure and Trigger node

From

Dave Page

Date:

22 July 2016, 15:38:45

Thanks, applied.

On Fri, Jul 22, 2016 at 8:56 AM, Harshal Dhumal
<harshal.dhumal@enterprisedb.com> wrote:
> Hi,
>
> PFA rebased patch for RM1293 and RM1294.
>
> --
> Harshal Dhumal
> Software Engineer
>
> EnterpriseDB India: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Mon, Jun 6, 2016 at 7:17 PM, Surinder Kumar
> <surinder.kumar@enterprisedb.com> wrote:
>>
>> Hi,
>>
>> Please find updated patch:
>> Issue: Code changes are not consistent with the present code in
>> functions/__init__.py, like don't rename variable func_def to func_defintion
>> until it is required.
>> Review comment given by Ashesh personally.
>>
>> Please review.
>>
>> On Fri, Jun 3, 2016 at 3:31 PM, Surinder Kumar
>> <surinder.kumar@enterprisedb.com> wrote:
>>>
>>> Hi,
>>>
>>> Please find attached patch for:
>>> 1. RM#1293 - SQL pane is not displaying GRANT queries in functions node
>>> 2. RM#1294 - Comments are not visible in sql pane for trigger functions
>>> and functions
>>>
>>> Explanation:
>>> Previously we we using 'get_defintion.sql' template to generate SQL for
>>> SQL pane for functions, procedure & trigger functions node.
>>> but GRANT statements and COMMENTS changes were missing. In order to fix
>>> that, now we have used both 'create.sql' and 'get_definition.sql' templates
>>> to generate full SQL query
>>> for SQL pane.
>>>
>>> Please review.
>>>
>>> On Thu, Jun 2, 2016 at 7:32 PM, Surinder Kumar
>>> <surinder.kumar@enterprisedb.com> wrote:
>>>>
>>>> Please ignore this patch. I will send another patch.
>>>>
>>>> On Thu, Jun 2, 2016 at 7:25 PM, Surinder Kumar
>>>> <surinder.kumar@enterprisedb.com> wrote:
>>>>>
>>>>> Hi,
>>>>>
>>>>> Please find attached patch for RM#1293.
>>>>> Add support to display GRANT privilege query in SQL Pane.
>>>>>
>>>>> Please review.
>>>>>
>>>>> Thanks,
>>>>> Surinder Kumar
>>>>
>>>>
>>>
>>
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company