Thread: [pgAdmin4][Patch]: number.toFixed is not function
Hi
Please find the patch
Issue:
We got the following error in console log
"number.toFixed is not function"
Steps to reproduce:
1) Click on statistics tab.
1) Select any database node.
2) then select Databases collection node.
3) The above error will appear into console.
Reason:
I discussed the issue with @Murtaza and here we are explicitly
converting values at server side to string as JSON do not directly
support NaN & Infinity values. Because of which NumberFormatter receives
values of type string and breaks.
Solution:
Overrides the NumberFormatter to support NaN & Infinity values.
and we need to parse the values again in float at client side.
Please review.
Thanks,
Surinder Kumar
Attachment
Thanks, applied. On Thu, Jun 23, 2016 at 7:53 AM, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote: > Hi > > Please find the patch > Issue: > We got the following error in console log > "number.toFixed is not function" > > Steps to reproduce: > 1) Click on statistics tab. > 1) Select any database node. > 2) then select Databases collection node. > 3) The above error will appear into console. > > Reason: > I discussed the issue with @Murtaza and here we are explicitly > converting values at server side to string as JSON do not directly > support NaN & Infinity values. Because of which NumberFormatter receives > values of type string and breaks. > > Solution: > Overrides the NumberFormatter to support NaN & Infinity values. > and we need to parse the values again in float at client side. > > Please review. > > Thanks, > Surinder Kumar > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company